Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Next challenges

Recent achievements

  • Global
  • Personal

Recognition

  • Give kudos
  • Received
  • Given

Leaderboard

  • Global

Trophy case

Kudos (beta program)

Kudos logo

You've been invited into the Kudos (beta program) private group. Chat with others in the program, or give feedback to Atlassian.

View group

It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

change event is fired once for a select if dialog is escaped or clicked out side

I am trying to write this simple javascript logic to disable multiselect field if user chose specific options from another select field. This is a JIRA dialog2, so I am using their JQuery namespace (eg: AJS).
Problem is when i open the dialog and select the specific values from the select field the handler for the change event of the select field runs properly and the other multiselect field is disabled. However, the snippet is not called/doesn't run if the dialog got closed by either pressing escape button or clicking outside it, as opposed to closing it by clicking the 'close' button. I am not a js expert and would appreciate any help in this.
Thanks

(function ($) {
      $(function () {
        AJS.dialog2.on("show", function (e) {
            var targetId = e.target.id;
            var spinning = false;
            if (targetId == "sr-dialog") {
              //start of the part that fails
              //noticing that the change event for the searchtypeselect field is fired only when the dialog shows up first time and re shows again only if the dialog got closed by the 'close' button. If dialog escaped it doesn't fire anymore.
              var $searchTypeSelect = AJS.$("#select-searchtype");
              var $fieldMultiSelect = AJS.$("#field-multiselect");
              $searchTypeSelect.change(function (e) {
              if ($searchTypeSelect.val() == 'D' || searchTypeSelect.val() == 'S') {                
                $fieldMultiSelect.removeAttr('disabled');
                } else { 
                $fieldMultiSelect.attr('disabled', 'disabled').val('');
               }
              }).trigger('change');
             // end of the part that fails
              AJS.$(e.target).find("#submit-spinner-trigger").click(function (e) {
                 var number = AJS.$("input[type=radio]:checked","#topSearchForm").val();
                 var searchType = AJS.$("#select-searchtype option:selected","#topSearchForm").val();
                 var fields = [];
                 AJS.$("#field-multiselect :selected","#topSearchForm").each(function(i,selected){
                   fields[i] = $(selected).val();
                });
                 var since = AJS.$("#select-since option:selected","#topSearchForm").val();
                 if (!spinning) {
                   AJS.$('.button-spinner').spin();
                   spinning = true;
               }               
              });
            }
        });
    });
})(AJS.$);

1 answer

1 accepted

1 vote
Answer accepted

I'd guess that the close button removes the dialog from the DOM, and clicking outside hides it. If you only hide the dialog and later you show a new dialog there will be multiple items with the same id's in the DOM (e.g.  #select-searchtype) and the AJS.$ calls (e.g. AJS.$("#select-searchtype")) will not work properly which will cause the behaviour you have observed.

So, is it better to ensure removing it from the DOM on clickoutside or escape?

That, or you can try using classes and attaching events/handlers to the elements of the dialog you are currently displaying(e.g.  var $searchTypeSelect = $(e.target).find('.searchType'), or s.th. like that).

@Peter Geshev [Botron], Thanks for the help. attaching the handler solved the issues and now it is working properly.

Suggest an answer

Log in or Sign up to answer
TAGS

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you