• Community
  • Questions
  • basic feature missing: full-source pre-commit code reviews with Perforce

basic feature missing: full-source pre-commit code reviews with Perforce

This is a feature request. My company is on JIRA and Confluence and would love to integrate Crucible, but this is a deal-breaker and until the feature is part of Crucible we will continue to use Reviewboard.

Use case: developer shares full-source code review before checking in code

Source control system: perforce

Expected success steps:

1. Developer has a perforce change list with local edits to a set of files.

2. Developer creates (through a simple script or action) a review of the changelist.

3. Developer publishes the review to the team.

4. The team is able to review diffs for all files in the pending changelist, including full source with the diffs (not just partial patch).

5. Team members ok the review.

6. Developer submits the changelist.

This use case is fully implemented by Reviewboard using their post-review command-line tool and perforce integration. There are other things we'd like from crucible but we won't sacrifice this most essential use case.

Also, a related use case would be to update an existing review when further changes are made to the same perforce changelist locally (but still not checked in) - e.g. correcting issues that reviewers found. Reviewboard also supports this, calling post-review on the same changelist will update the diffs to reflect the latest changes on the developer's local filesystem.

Thanks for considering this feature request, please do send a note if you ever implement and we will re-evaluate a purchase of crucible.

Best regards,

Chris Corbell


3 answers

That strikes me as a clunky, incomplete "solution".

My company created a skunkworks project (https://github.com/Netflix-Skunkworks/post2crucible.git) to emulate the steps described above. But now we have to maintain the tool. It seems to me that, since Atlassian is in the code review business, you guys could (and should) provide such a tool. Is there any hope of that happening?

you can upload the files using curl for pre commit, either you can use the password or generate the token and parse the file for upload

system("curl --cookie remember=$token -X POST -F file=\@${files} http://fisheyehost:8060/rest-service/reviews-v1/$reviewid/addFile ");

0 vote

It seems that you are looking for this feature request: https://jira.atlassian.com/browse/CRUC-3378

Suggest an answer

Log in or Join to answer
Community showcase
Alexey Matveev
Published Saturday in Jira

How to run Jira in a docker container

Everything below is tested on Ubuntu 17.10. I prefer to use Jira in a docker container because: 1. I can install Jira with a couple of commands. 2. I can start and stop Jira just by starting and s...

153 views 3 7
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you
Atlassian Team Tour

Join us on the Team Tour

We're bringing product updates and pro tips on teamwork to ten cities around the world.

Save your spot