Stash pull request behavior

Two questions about pull requests with stash.

One

Current stash documentation describes the following behavior for comments as pull requests are updated:

Participants can commit new changes to the branch. Stash auto-updates the Commits tab of the pull request, so you can see exactly which commits will be merged. Stash is smart about comments, moving them along when lines are added or removed. If a line with a comment gets removed, you can still view the comment in the activity, but Stash marks the diff as outdated to let you know that this piece of code has been changed in recent commits.

Would it be possible instead to simply leave comments on the "commits" tab, rather than the "diff" tab, which is silo'ed per commit? In this case, comments could be immutable, and would be easier to track the iterative feedback/code change loop. This seems to be the way Gerrit handles the evolution of a code review, as you can see for example here.

Two

In Stash 2.3, it seems like every individual comment sends an email. Would it be possible to have all comments batched as a single piece of feedback, triggered when the pull request is approved or denied? Again, this is how Gerrit operates -- comments are 'drafts' until the reviewer submits with a score.

If these are reasonable questions, I am happy to submit them as feature requests for Stash via Jira.

Thanks!

1 answer

1 vote
Seb Ruiz Atlassian Team Apr 06, 2013

Hi Jacob,

Both of these are existing feature requests:

Commit comments: STASH-2511

Notifications: STASH-2839 / STASH-3259

Regards,

Seb

Suggest an answer

Log in or Sign up to answer
Atlassian Community Anniversary

Happy Anniversary, Atlassian Community!

This community is celebrating its one-year anniversary and Atlassian co-founder Mike Cannon-Brookes has all the feels.

Read more
Community showcase
Piotr Plewa
Published Dec 27, 2017 in Bitbucket

Recipe: Deploying AWS Lambda functions with Bitbucket Pipelines

Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda&nbsp...

1,749 views 1 5
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you