Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Don't remove PR approvals on sync/merge from its destination branch?

Phil Wilkinson June 14, 2019

So we'd like to utilise the premium feature in the 'Branch permissions' section titled: "Approvals are reset when the source branch is modified"

Our process is as follows:

  1. Code is written
  2. PR is created
  3. Other devs approve or leave comments
  4. Once the PR has 2+ approvals, it's ready for testing/QA
  5. At some point, the work is selected for QA
  6. The PR is brought up to date with its destination branch
  7. PR is deployed for testing
  8. After approval PR is now ready for merging, etc

Now, our tester typically ensures that the branch is up to date with the branch that the PR is pointing at (item 6 on the above process list).  This merge/sync updates the source branch and understandably loses all reviewers. 

Most of the time, however, the work in the branch (compared to its destination, i.e. diff) has not changed (no conflicts), so this is not at all helpful in practice.

 

Is there a way to not remove approvals on a sync/merge from its destination branch?

0 answers

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events