Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Add "Clarification required" option when review pull requests

okikhtov June 3, 2020

When we review pull requests in bitbucket there are 2 options there: 

- Approve

- Needs work

But in our company we noticed that its not enough. Because very often we have such situation - pull request looks fine and there is no reason to mark it as "Needs work". In the same time you can not approve it because some code is not clear to you or you are not sure whether its correct approach. So you need to ask author to explain that. If you write the comment and then wait for fix - then you will need to review whole PR again even if some minor changes were done there because only "Approve" or "needs work" let you review the changes that were done after you reviewed the PR.

So it would be good to have third option "Needs clarification" or "Clarification required". Once you choose that - for author it means that you are almost ok with PR but would like to get more info from him. 

0 answers

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events