When we review pull requests in bitbucket there are 2 options there:
- Needs work
But in our company we noticed that its not enough. Because very often we have such situation - pull request looks fine and there is no reason to mark it as "Needs work". In the same time you can not approve it because some code is not clear to you or you are not sure whether its correct approach. So you need to ask author to explain that. If you write the comment and then wait for fix - then you will need to review whole PR again even if some minor changes were done there because only "Approve" or "needs work" let you review the changes that were done after you reviewed the PR.
So it would be good to have third option "Needs clarification" or "Clarification required". Once you choose that - for author it means that you are almost ok with PR but would like to get more info from him.
Hi everyone, We are looking to learn more about development teams’ workflows and pain points, especially around DevOps, integrations, administration, scale, security, and the related challeng...
Connect with like-minded Atlassian users at free events near you!Find an event
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no Community Events near you at the moment.Host an event
You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events