Hi,
I do like the feature of being warned about code that was not reviewed. All our code should go through a review with the pull-request process.
Still there are some warnings that occur in cases where the branch that contains the code, was not part of a pull-request and was therefore not merged – and reviewed.
This might be because it was realized that the code/branch is not needed due to different reasons (not now, not never, was a test spike not making it into the prod branch, …).
Is there a way to mark the code as OK not to be reviewed for that version – so that the warning goes away?
Removing the whole ticked from the version seems incorrect, as the content in the ticket (even if not the code) does correspond to the version.
In a perfect world that might not be an issue, but I face this situation at least once a release :D
I found that there is the possibility to create a pull-request and decline it as only workaround – the warning would go away, but I don’t think that is supposed to be the right way.
Community moderators have prevented the ability to post new answers.
Hi @paul_finnedison ,
It's been a while since this was posted, so I just wanted to check if you've managed to resolve this?
Also, just to clarify, are the warnings you're seeing generated within JSM itself, or are they coming from an integrated tool like Bitbucket?
Asking because the question is located in the JSM forum group, and it's not quite clear to what you're referring when you talk about these warnings. 👀
Cheers,
Tobi
@Tomislav Tobijas, this topic has been locked because the thread has become a bit dated. If you’d like to keep the conversation going or have additional questions, we encourage you to start a new topic. You can read more about necro posting (“raising threads from the dead”) in our Community Guidelines.
Thanks!
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.
You must be a registered user to add a comment. If you've already registered, sign in. Otherwise, register and sign in.