The Atlassian Community Forums are currently in read-only mode. We will be relaunching on a new platform on September 22 (read more here). We apologize for the extended downtime. For concerns or questions, please email communitymanagers@atlassian.com. See you on the other side, on the new Atlassian Community Forums! :)

×

Forums

Articles
Create
cancel
Showing results for 
Search instead for 
Did you mean: 

"Auto Unapprove for Bitbucket Server" plugin doesn't react to whitespace changes

avsaditya
February 4, 2020

Hello,

While using the plugin "Auto Unapprove for Bitbucket Server", it was noticed that the automatic "unapproval" is provided only for changes other than whitespaces/tabs.

I don't see any configuration to enable this either globally or at project level.

Any help is appreciated.

Thanks and Regards

Aditya

2 answers

1 accepted

Comments for this post are closed

Community moderators have prevented the ability to post new answers.

1 vote
Answer accepted
avsaditya
February 6, 2020

Depending on the changes being made, it's likely that it is intended functionality - as the unapprove plugin will not look to trigger unless one of the following occurs:

If a declined pull request is reopened
If, after a commit, the rescope updated the pull request's diff. If the pull request rescope does not change the diff, then approvals will not be reset.
If the pull request's target branch has changed, and the new branch refers to a different commit than the previous branch. If the new branch refers to the same commit as the previous branch, approvals will not be reset.

In this case, when you add whitespace - what's likely happening is that although a new commit is being pushed, it's not updating the generated diff where a unique/different patch id is being generated, which would be the trigger for the auto-unapprove plugin to kick in.

0 votes
Daniel Joseph
Banned
September 12, 2024

It seems the plugin is working as designed. It triggers with changes like reopening a declined pull request, updating the diff, or changing the target branch. Adding whitespace might not create a new diff, so the plugin doesn’t activate.

TAGS
AUG Leaders

Atlassian Community Events