External Pre-Recieve plugin Error

[Madhu Padikar]

HI

we are using External Pre-Recieve plugin for our organization. when users do push to the repo they are getting following error.

Counting objects: 5, done.

Writing objects: 100% (3/3), 249 bytes | 0 bytes/s, done.

Total 3 (delta 0), reused 0 (delta 0)

remote: Hook com.ngs.stash.externalhooks.hook.ExternalPreReceiveHook failed. Er

or:

remote: Permission is not a resource-based permission

To https://padikm@asdstash.isus.emc.com:8443/scm/io/notifier.git

! [remote rejected] release-9.2 -> release-9.2 (pre-receive hook declined)

error: failed to push some refs to 'https://padikm@asdstash.isus.emc.com:8443/s

m/io/notifier.git'

can any one please let me now the user level permissions for the repos to be given so that this works properly. Urgent help is needed.

[Michael Heemskerk]

Hi Madhu,

That looks like a programming error in the ExternalPreReceiveHook class. They're calling PermissionService.hasAnyPermissions which can only be called with a PROJECT or REPO permission. In the code, it's being called with a global permission (SYSADMIN and ADMIN).

Note that this will only throw an exception if the user has insufficient permissions. If you make the user administrator on the repository or project, the check will succeed.

Edit: issue created: https://github.com/ngsru/atlassian-external-hooks/issues/3

Cheers,

Michael

[Madhu Padikar]

Thanks a lot. That worked for me. Now no errors :). Sorry for the late reply. :(

[Madhu Padikar]

HI Michael

Thanks much for the reply. i have source code. can i modify and change the permission?

regards

Madhu

[Michael Heemskerk]

Madhu,

It looks like Charles O'Farrell beat you to it.. :) There's an outstanding pull-request with fixes to this issue: https://github.com/ngsru/atlassian-external-hooks/pull/4

You can clone Charles's fork and build the patched version yourself.

Cheers,

Michael