Issue with Custom Action calling Explorer in Windows

[Nick Henry]

I made a batch file that calls c:\windows\explorer.exe with parameters

The script works fine, but even if the batch file only contains:

`explorer`

Source tree indicates: 'Completed with errors, see above.'

To recreate:

Create custom action

Set 'Script to run' to the batch file to be ran

In the batch file have one line command `explorer`

Set Parameters to `$REPO $FILE`

Here's my actual script I'm trying to run: (ExploreRepoFilePath.bat)

ECHO OFF
SET FullPath=%1\%2
SET DirectoryPath=%~dp2
if exist %FullPath% (
c:\windows\explorer.exe /select,%FullPath:/=\%
exit
)
if exist %DirectoryPath% (
c:\windows\explorer.exe %DirectoryPath%
exit
)

c:\windows\explorer.exe %1

EXIT /B 0

[Mike Corsaro · Accepted solution]

Hello! This is actually a problem in your script. You have the "EXIT /B 0" at the end of the file, but you don't return exit code 0 for the other 2 exits. Sourcetree uses the exit code to determine if it's successful or not. The fixed script should look like this:

ECHO OFF
SET FullPath=%1\%2
SET DirectoryPath=%~dp2
if exist %FullPath% (
c:\windows\explorer.exe /select,%FullPath:/=\%
EXIT 0
)
if exist %DirectoryPath% (
c:\windows\explorer.exe %DirectoryPath%
EXIT 0
)

c:\windows\explorer.exe %1

EXIT /B 0

[Nick Henry]

Thanks Mike, I didn't think about that, figured it was something with calling Explorer specifically.

It's totally working now with no errors! thanks again.