It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Issue with Custom Action calling Explorer in Windows

I made a batch file that calls c:\windows\explorer.exe with parameters

 

The script works fine, but even if the batch file only contains:

`explorer`

Source tree indicates: 'Completed with errors, see above.'

 

To recreate:

Create custom action

Set 'Script to run' to the batch file to be ran

In the batch file have one line command `explorer`

Set Parameters to `$REPO $FILE`

 

Here's my actual script I'm trying to run: (ExploreRepoFilePath.bat)

ECHO OFF
SET FullPath=%1\%2
SET DirectoryPath=%~dp2
if exist %FullPath% (
c:\windows\explorer.exe /select,%FullPath:/=\%
exit
)
if exist %DirectoryPath% (
c:\windows\explorer.exe %DirectoryPath%
exit
)

c:\windows\explorer.exe %1

EXIT /B 0

1 answer

1 accepted

2 votes
Answer accepted
Mike Corsaro Atlassian Team Oct 18, 2017

Hello! This is actually a problem in your script. You have the "EXIT /B 0" at the end of the file, but you don't return exit code 0 for the other 2 exits. Sourcetree uses the exit code to determine if it's successful or not. The fixed script should look like this:

 

ECHO OFF
SET FullPath=%1\%2
SET DirectoryPath=%~dp2
if exist %FullPath% (
c:\windows\explorer.exe /select,%FullPath:/=\%
EXIT 0
)
if exist %DirectoryPath% (
c:\windows\explorer.exe %DirectoryPath%
EXIT 0
)

c:\windows\explorer.exe %1

EXIT /B 0

Thanks Mike, I didn't think about that, figured it was something with calling Explorer specifically.

 

It's totally working now with no errors! thanks again.

Suggest an answer

Log in or Sign up to answer
TAGS
Community showcase
Published in Sourcetree

Sourcetree for Windows - CVE-2019-11582 - Remote Code Execution vulnerability

A vulnerability has been published today in regards to Sourcetree for Windows.  The goal of this article is to give you a summary of information we have gathered from Atlassian Community as a st...

4,910 views 0 12
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you