Issue with Custom Action calling Explorer in Windows

I made a batch file that calls c:\windows\explorer.exe with parameters

 

The script works fine, but even if the batch file only contains:

`explorer`

Source tree indicates: 'Completed with errors, see above.'

 

To recreate:

Create custom action

Set 'Script to run' to the batch file to be ran

In the batch file have one line command `explorer`

Set Parameters to `$REPO $FILE`

 

Here's my actual script I'm trying to run: (ExploreRepoFilePath.bat)

ECHO OFF
SET FullPath=%1\%2
SET DirectoryPath=%~dp2
if exist %FullPath% (
c:\windows\explorer.exe /select,%FullPath:/=\%
exit
)
if exist %DirectoryPath% (
c:\windows\explorer.exe %DirectoryPath%
exit
)

c:\windows\explorer.exe %1

EXIT /B 0

1 answer

1 accepted

2 votes
Mike Corsaro Atlassian Team Oct 18, 2017

Hello! This is actually a problem in your script. You have the "EXIT /B 0" at the end of the file, but you don't return exit code 0 for the other 2 exits. Sourcetree uses the exit code to determine if it's successful or not. The fixed script should look like this:

 

ECHO OFF
SET FullPath=%1\%2
SET DirectoryPath=%~dp2
if exist %FullPath% (
c:\windows\explorer.exe /select,%FullPath:/=\%
EXIT 0
)
if exist %DirectoryPath% (
c:\windows\explorer.exe %DirectoryPath%
EXIT 0
)

c:\windows\explorer.exe %1

EXIT /B 0

Thanks Mike, I didn't think about that, figured it was something with calling Explorer specifically.

 

It's totally working now with no errors! thanks again.

Suggest an answer

Log in or Join to answer
Community showcase
Brian Ganninger
Published Jan 23, 2018 in Sourcetree

Tip from the team: workflow and keyboard shortcuts

Supported Platforms macOS Sourcetree has a lot to offer and, like many developer tools, finding and using it all can be a challenge, especially for a new user. Everyone might not love ...

267 views 0 3
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you
Atlassian Team Tour

Join us on the Team Tour

We're bringing product updates and pro tips on teamwork to ten cities around the world.

Save your spot