Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

svn pre-commit code review

wenjin
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
April 18, 2014

hello,

So far, I know how to create patch files for pre-commit code review in crucible. But we can still commit the code to svn repository if the code is not reviewed. I want the codes in svn repository are all reviewed. The codes not reviewed can not commit to svn repository. Should I write svn pre-commit hook? Please help me with this problem. Thanks

3 answers

0 votes
Midori
Rising Star
Rising Star
Rising Stars are recognized for providing high-quality answers to other users. Rising Stars receive a certificate of achievement and are on the path to becoming Community Leaders.
May 29, 2016

Your use case is not totally clear, but it sounds as you were to check if the commit message contains a code review number.

If that's some formatted expression (like "FOO-123"), then you can automate this with the Commit Policy Plugin. It has a condition that requires the commit message to match a regular expression, and you can use this to enforce entering the expression!

0 votes
wenjin
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
April 20, 2014

Do you use "grep" in pre-commit.bat to catch the key code review number? Is that review number linked to crucible? Can you show me your pre-commit hook? Thank you very much.

I do not know how to add the link number of crucible in our svn log.

0 votes
Norman Abramovitz
Rising Star
Rising Star
Rising Stars are recognized for providing high-quality answers to other users. Rising Stars receive a certificate of achievement and are on the path to becoming Community Leaders.
April 18, 2014

Yes, I would write a svn pre-commit hook because that is the only way to handle all different types of clients.

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events