The Atlassian Community Forums are currently in read-only mode. We will be relaunching on a new platform on September 22 (read more here). We apologize for the extended downtime. For concerns or questions, please email communitymanagers@atlassian.com. See you on the other side, on the new Atlassian Community Forums! :)

×

Forums

Articles
Create
cancel
Showing results for 
Search instead for 
Did you mean: 

Will Git commits be held up by code review process?

Deleted user
May 6, 2013

We've got a very small dev team with tight timetables and would really like a lot of the benefits that crucible has to offer for code review (inline comments/response capability). However we can't be hamstrung by sending out commits to our repository and needing to wait on a code review/sign off before the commits are in the repo.

My question is, is it possible to send the commits to the repository and then use the reviewing functionality after we've cut the latest deployment from our developers?

Thanks in advance for any answers!

1 answer

Comments for this post are closed

Community moderators have prevented the ability to post new answers.

1 vote
rstephens
Rising Star
Rising Star
Rising Stars are recognized for providing high-quality answers to other users. Rising Stars receive a certificate of achievement and are on the path to becoming Community Champions.
May 7, 2013

Hi Matt,

FishEYe/Crucible connect to an existing repository in a read-only way. It does not prevent a user from committing or restrict visibility of what has been committed - it instead provides review functionality after-the-fact, along with tools to audit what has and hasn't been through a review.

Kind Regards,
Richard Stephens

PS. Incidentallly, if you DID want to hold up commits by a code review process, you could look at pull requests in Stash. Stash can block pushes to the master branch except by certain users, and can require code to be merged by a reviewed pull request.

TAGS
AUG Leaders

Atlassian Community Events