Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,367,208
Community Members
 
Community Events
168
Community Groups

Marking crucible review comments as fixed/ignore/closed

When I work with a set of comments for my code review I'd like to have a workflow where I can tell if a comment has been addressed and been accepted by reviewers.

I compare Crucible to internal tools for code reviews at some large IT houses. These tools allows the author to mark comments as Fixed (or Resolved) or Won't Fix. The author then uploads a new iteration and the reviewers mark the comments as Closed or they can change the comment back to Open which means that the author has to do more work to address the comment. Authors and reviewers can filter the comments to only show comments that have not been closed yet.

Crucible has a feature to mark a comment as read. But this is personal and I cannot filter out read comments. I can only filter at file level. I use the Read/Unread marker to keep track of which comments I have addressed. But I'd like to see more such markers to support this workflow.

4 answers

1 accepted

4 votes

Other tools definitely have better methods for handling this.  Here's the closest workaround I've found with Crucible:

  • Go to Administration | Global Settings | Crucible. 
  • Edit Defect Classifications | Add a new Classification. 
  • Create a classification called Status. 
  • Ours has values for Open, Resolved, Postponed, Rejected, and Invalid.  Every defect (but not Comment, sorry) now has a method for Reviewers to provide feedback on the author's edits so far. 

Caveats:

  • Crucible ignores these values when it comes to assessing whether a review is ready to close.  We have to manually use Advanced Crucible Search to determine whether a review is really ready to close. 
  • Reviewers really need to have their profile set so that Crucible will "Uncomplete review if revision is added".  It's the only existing method for notifying them that the Author has posted fixes to defects that require them to go update their defects.
  • Only the Reviewers may change the Status of the defect.  The Author has no way to "check off" items already completed. 

Please go vote for CRUC-6160.  You might also consider CRUC-98

Hello @Sven Rosvall and thanks for this question. As @Tini Good mentioned, the best way to contribute to this feature's future is to upvote those JIRA issues mentioned above. We are now planning lots of interesting updates to improve Crucible experience, so I just wanted to let you know that we will be considering to put this feature into our roadmap.

I can suggest you to monitor this two issues (https://jira.atlassian.com/browse/CRUC-6160https://jira.atlassian.com/browse/CRUC-98) to stay in touch with the news.

Cheers,

Stan Gladkov

FishEye and Crucible Product Manager.

Thanks Tini. That helps. Have voted for those feature requests, definitiely what I am looking for.

Suggest an answer

Log in or Sign up to answer
TAGS

Atlassian Community Events