Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Next challenges

Recent achievements

Recognition

  • Give kudos
  • My kudos

Leaderboard

  • Global

Trophy case

Kudos (beta program)

Kudos logo

You've been invited into the Kudos (beta program) private group. Chat with others in the program, or give feedback to Atlassian.

View group

It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

I was wondering if there was any documentation on how to properly handle the following workflow:

- Create a review and add SVN revisions to it

- Review is done

- Author reviews comments, respond to them, makes some code changes and commits them

- ?? Add changes to review ??

- Reviewer looks at the new changes in the same crucible review

- Reviewer sends some new comments (and repeat the couple steps above until it is fine)

- Close the review

We use Jira integration and we also want to do same above with code patches sent in emails before commits...

I am having a hard time managing the ?? ?? part above on how to add the changes to a review and make this easy to do some back and forth.

I saw many documentation on this flow, but none take consider the coder making some changes..

How do you all do that? Am I doing it wrong?

Thanks

1 answer

1 accepted

1 vote
Answer accepted

We usually have the assigned Moderator ensure that the workflow we've defined is followed, the tool itself doesn't really do that.

Our process has the Author reply to each comment with an accept/reject/other decision. This gives the review team the opportunity to "discuss" the decision. Appropriate updates are made and comitted, and then the Author adds the updated changesets for reviewer(s) and moderator to confirm all corrections are made. Crucible recognizes when the file/changeset has a newer version (via Fisheye), so the Author can easily add the new version for comparison (see User Guide for Crucible 2.9 at page 72 "When Files Change During Review).

In the event a defect requires a more detailed fix, a JIRA Issue is created so the review doesn't stay open past the due date.

Suggest an answer

Log in or Sign up to answer
TAGS
Community showcase
Published in Confluence Cloud

Share your Confluence Cloud experience for a chance to win $500!

Take our 5-minute survey to win a $500 Visa gift card! Are you currently using Confluence Cloud? We want to hear from you! Fill out this quick survey about your Confluence Cloud experience so we ...

240 views 5 13
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you