Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in
It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Crucible: how to review a series of patch?

In crucible, I need to review series of multiple patches (a dozen of patches). Each commit has its own logic and must be reviewed separately (and whole is to big to reviewed all at once). Obviously, the series is also a set of coherent changes and, reviewer has sometime to refere to previous commit or suggestion.

I do not see how to review this without creating one review for each commit which is absolutly unusable and make no-sense.

2 answers

0 votes
Ben Stuart Atlassian Team Jul 31, 2018

Hey again, 

Would adding multiple change-sets or patches to a review work for you rather than an entire branch? See Adding content to the review for the details on that. If not, can you explain why? 

Thanks and best regards,
Ben Stuart

You are right, I can add multiple change-set to a review. However:

1. I am impacted by this bug

2. Interface is terrible. Here, an example with 5 change-sets:

Screenshot_2018-08-06 CR-26 upstream fix compat with kernel = 4 12 - Under Review.png

0 votes
Ben Stuart Atlassian Team Jul 11, 2018

Hey Jérôme, 

I'm not sure I understand your question. You can certainly review multiple patches or revisions in a single review, but it sounds like that doesn't work for you wither? 

I think the confusion is around your statement:

Each commit has its own logic and must be reviewed separately

Can you clarify what behaviour you're looking for/ expecting in Crucible?

Hello Ben,

I am able to select a branch to review, but it just show me diff between content before the branch and after the branch. I need to review intermediate commits.

For comparaison, my usual process is:

  • get commits with "git format-patch" (or "git send-email")
  • prepend all lines of patches with "> " ("sed -i 's/^/> /' *.patch")
  • use an editor with correct syntax highlight to add my comments

Screenshot_20180712_104322.png

Suggest an answer

Log in or Sign up to answer
TAGS
Community showcase
Published in Jira

Do you use Jira Cloud with Microsoft Teams?

Hi, Jira users! Do you use Jira alongside Microsoft Teams? We want to hear how you’ve used the power of Jira Cloud and Microsoft Teams (via the Jira Cloud for Microsoft Teams app) to achieve a team...

384 views 1 6
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you