Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,298,137
Community Members
 
Community Events
165
Community Groups

Creating reviews automatically from changesets

Hi,

I'm using Mercurial (hosted at BitBucket) and currently evaluating Crucible as a code review tool for my team. We have one fairly critical repository where we would like to setup reviews for each changeset pushed to that repository (optionally excluding some individual commits by some special string inside commit message). Is this kind of workflow possible in Crucible?

5 answers

1 accepted

2 votes
Answer accepted

There is the Automatic Review Creator but unfortunately it's incompatible with recent Crucible versions.

In my opinion (of course, there are always exceptions), creating a review for each revision might be a bit excessive in many cases.

I would say that is much more realistic using a repository browser deeply integrated with JIRA. In that way, users might view when code has been reviewed or not while them explore changes: log/history command, revision graphs, open a file, and so on.

In addition, users should be able to ask for review from JIRA if they want to be sure that code is ok. Simply: click on a revision and ask for review.

That integrated repository browser should also be able to filter changes by user allowing to review changes made by a recently hired employee, by example.

If you are using Subversion then there is available a plugin providing all features described above and much more.

I've got a great solution if you're arriving at this thread looking for a script to automate review creation (or just some Python to illustrate how to use the REST API) ... introducing Mullite!

https://github.com/60East/mullite

Clone it, write your config file, cron it and you're set!

You can use mercurial post commit hook and create a script using the Crucible API:

http://confluence.atlassian.com/display/FECRUDEV/REST+API+Guide

to create a review after each commit.

I was actually been able to install that plugin into Crucible 2.6.0 and it seems to work quite nicely, but it doesn't quite support Iterative Reviews. Even if I enable the "Enable iterative reviews" checkbox in settings in the Administration section, it still creates new reviews automatically for those changesets which contain only changes which are part of files under existing reviews.

It would be nice if the code author who receives review feedback could commit fixes with some special commit message prefix (e.g. the code review ID) so that Crucible would know that this specific commit is associated with this specific, existing review, and that no new reviews should be created automatically. Is there such a feature?

Suggest an answer

Log in or Sign up to answer
TAGS
Community showcase
Published in Confluence

An update on Confluence Cloud customer feedback – June 2022

Hi everyone, We’re always looking at how to improve Confluence and customer feedback plays an important role in making sure we're investing in the areas that will bring the most value to the most c...

154 views 1 3
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you