Code review before checking in

[Rahul Aich [Nagra]]

My organisation are using Fisheye/Crucible for code review. However I think it has a serious failing in that code review is always done AFTER check-in. So code review is something done after potentially bad code has been checked in.

Is there any way we can configure fisheye/crucible so that code is only checked in to Our version control tool i.e. Perforce after it has been through review?

Rahul

[Piotr Swiecicki · Accepted solution]

Hi Rahul,

The model you described is indeed more often used as most customers find it easier to have the proposed changes checked in on a dedicated feature branch, have it reviewed and merged to default only when the review was approved.

But Crucible allows to do pre commit reviews too. See https://www.atlassian.com/software/crucible/overview/code-review-pre-commitand https://confluence.atlassian.com/display/CRUCIBLE/Creating+patch+files+for+pre-commit+reviewsfor more details. Basically it requires code author to create a patch and add this to review. Note this can be easily done with a command line tool prepared for this purpose, see https://confluence.atlassian.com/display/CRUCIBLE/Creating+reviews+from+the+command+line.

Hope that helps,
Piotr

[Rahul Aich [Nagra]]

Thanks Piotr