Code review before checking in

My organisation are using Fisheye/Crucible for code review. However I think it has a serious failing in that code review is always done AFTER check-in. So code review is something done after potentially bad code has been checked in.

Is there any way we can configure fisheye/crucible so that code is only checked in to Our version control tool i.e. Perforce after it has been through review?

Rahul

1 answer

1 accepted

1 vote

Hi Rahul,

The model you described is indeed more often used as most customers find it easier to have the proposed changes checked in on a dedicated feature branch, have it reviewed and merged to default only when the review was approved.

But Crucible allows to do pre commit reviews too. See https://www.atlassian.com/software/crucible/overview/code-review-pre-commitand https://confluence.atlassian.com/display/CRUCIBLE/Creating+patch+files+for+pre-commit+reviewsfor more details. Basically it requires code author to create a patch and add this to review. Note this can be easily done with a command line tool prepared for this purpose, see https://confluence.atlassian.com/display/CRUCIBLE/Creating+reviews+from+the+command+line.

Hope that helps,
Piotr

Suggest an answer

Log in or Sign up to answer
How to earn badges on the Atlassian Community

How to earn badges on the Atlassian Community

Badges are a great way to show off community activity, whether you’re a newbie or a Champion.

Learn more
Community showcase
Published yesterday in Confluence

Three common content challenges + how to manage them

An efficient enterprise content management system, or ECM, is a must-have for companies that create work online (cough   cough, all companies). If content calendars, marketing plans, and bu...

70 views 0 4
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you