Blocking commits using svn and crucible until it get reviewed

[elhmarouan]

Is there any possibility to block SVN commits until it get reviewed and approved by Atlassian Crucible code reviewers ? I want to do something similar to Gerrit but using SVN, i heard that it can't be done with centralized control version systems, if it were for me i'd rather move to Git, but is there some alternative solution ?

[Felipe Kraemer · Accepted solution]

Hi Marouan,

I thought about creating a pre-commit patch review and then making the SVN pre-commit hook call this REST resource using cURL / wget in order to search for reviews which include a particular file from the pre-commit patch, iterate over the results, and then:

1. If a review is returned, check if its status is Closed. 
   1. If it's not Closed, block the commit.
   2. If it's Closed, allow the commit.
2. If no reviews are returned, block the commit.

I believe this would work perfectly to you, but while investigating this I've discovered that the REST resource does not return reviews based on files from pre-commit patches. It only returns reviews based on revisions that have already been committed.

I have created an improvement request in our development issue tracker in order to make that REST resource include reviews based on files from pre-commit patches:

https://jira.atlassian.com/browse/CRUC-7198

Feel free to vote for the issue and/or leave a comment to describe your use-case in more detail. It will help our development team to build a solution that meets your needs.

If you want to know more about how we prioritise feature requests, take a look at our policy.

If this answer was helpful, please allow me to ask you to mark my answer as accepted in order to have it in the top of the thread, also helping other customers.

Thanks in advance!

Kind regards,
Felipe Kraemer

[elhmarouan]

Thanks for your answer ! So is it possible to use the Crucible Review CLI tool to block commits by developers and send the diff to Crucible review instead ?