I'm looking to make code reviews a required step to accept code into our code base. Been playing with Stash & Crucible to see how they could be setup to help me accomplish this, but am struggling to find a good answer.
To start with, I think the basic features I'm looking for (with the https://www.atlassian.com/git/workflows#!workflow-feature-branch in mind) are:
Stash, via the "pull request" system seems to cover only #2 (and #5?), but not the rest, although it's pretty close on #1 as it has ACLs for branches, but not based on pull request status.
Crucible, surprisingly seems to fall short on all fronts. (uh?!) What am I missing here?
Curious about whether I'm looking at this the wrong way, or whether there are plugins/hooks that'd do the job here.
How did you go?
1. This isn't currently possible without writing your own plugin. You might be interested in the following:
3. Again you could do this with a plugin. There are quite a few open feature requests around reviewers, but nothing that matches that exact requirement. You might want to do a quick Google if you're interested. See below also.
4. People with write access should be able to approve without being a reviewer. Is that what you had in mind?
5. Again, people with access should be able to add themselves or others to a pull request.
In general we're planning on enhancing the whole pull request experience in feature releases. I can't be more specific around dates or exact features, but we'll certainly be keeping 1 and 3 in mind.
Badges are a great way to show off community activity, whether you’re a newbie or a Champion.Learn more
...attest to the experience of an urgent approval that gets lost in the boss’s inbox and requires that special “Please Approve” email or text message. In an age where we have distributed teams...
Connect with like-minded Atlassian users at free events near you!Find a group
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no AUG chapters near you at the moment.Start an AUG
You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs