"Auto Unapprove for Bitbucket Server" plugin doesn't react to whitespace changes

[avsaditya]

Hello,

While using the plugin "Auto Unapprove for Bitbucket Server", it was noticed that the automatic "unapproval" is provided only for changes other than whitespaces/tabs.

I don't see any configuration to enable this either globally or at project level.

Any help is appreciated.

Thanks and Regards

Aditya

[avsaditya · Accepted solution]

Depending on the changes being made, it's likely that it is intended functionality - as the unapprove plugin will not look to trigger unless one of the following occurs:

If a declined pull request is reopened
If, after a commit, the rescope updated the pull request's diff. If the pull request rescope does not change the diff, then approvals will not be reset.
If the pull request's target branch has changed, and the new branch refers to a different commit than the previous branch. If the new branch refers to the same commit as the previous branch, approvals will not be reset.

In this case, when you add whitespace - what's likely happening is that although a new commit is being pushed, it's not updating the generated diff where a unique/different patch id is being generated, which would be the trigger for the auto-unapprove plugin to kick in.