pull request code review

we have a developper that makes the code review of the pull request. and some of the comments he made are only shown in the "overview" tab of the pull request, but not in the "diff" tab.

 

also some comments were lost and we are not sure why.

2 answers

0 vote

HI Denys,

I attempted to reproduce this issue in BitBucket server and was able to see the comments in the diff and the overview tab.  Can you provide the exact steps the developer goes through to perform the code review?

Cheers,

Branden

we are investigating a bit more on this, and found that the comments were actually not lost, they are just not visible on teh side-by-side window, and they are visible on the "unified" window.

 

attached are 2 screenshots of the same pull request, with difference of only few seconds (the time that took me to switch to side by side window) and you can see that on the same lines where unified shows the comments, side by side is not showing anything..bitbucket_error_side_by_side.jpg.pngbitbucket_error_unified.jpg

but at other places of the same file, side by side does show some comments, but not all the comments that we can see iin the "unified view".

Suggest an answer

Log in or Sign up to answer
How to earn badges on the Atlassian Community

How to earn badges on the Atlassian Community

Badges are a great way to show off community activity, whether you’re a newbie or a Champion.

Learn more
Community showcase
Posted Jun 12, 2018 in Bitbucket

Do you use any Atlassian products for your personal projects?

After spinning my wheels trying to get organized enough to write a book for National Novel Writing Month (NaNoWriMo) I took my affinity for Atlassian products from my work life and decided to tr...

136 views 17 7
Join discussion

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you