What exactly happens when you decline a pull request in Stash?

The Stash documentation on pull requests does not detail in any way what exactly happens when you 'decline' a pull request. If I am added as a reviewer and I have a comment on the pull request, should I decline the pull request as well? Or just add a comment and wait until the pull request is updated again for my comment?

1 answer

1 accepted

8 votes
Seb Ruiz Atlassian Team May 27, 2013

Hi Wim,

Declining a pull request is an indication that the pull request should probably never be merged to the destination branch. You might decline a pull request if: there are serious architectural problems with the incoming changes, there are philosophical conflicts in the changes or the code changes are no longer relevant (or will be incorporated in a few months time, perhaps).

If the pull request requires rework, then we suggest leaving the pull request open until those changes are pushed to the source branch, when the pull request will be updated automatically and show the new changes. You will be notified when changes are made to the pull request.

Of course, you might want to restrict who can merge a pull request given certain conditions. This can be done using branch permissions and/or merge checks. You can even build your own merge checks.

Hope that helps,
Seb

Can this be added to the Stash documentation please?

The problem with this workflow is there's no effective way to say "I'm done reviewing and this is not approved". Users will be notified of each comment you make and have no way of knowing whether or not you've completed your review or were pulled into a meeting halfway through it.

Hi Kenneth,

We're definitely aware of that and are looking to improve this experience in a future version. You might be interested in:

https://jira.atlassian.com/browse/STASH-2999

Cheers,

Charles

Suggest an answer

Log in or Sign up to answer
Atlassian Community Anniversary

Happy Anniversary, Atlassian Community!

This community is celebrating its one-year anniversary and Atlassian co-founder Mike Cannon-Brookes has all the feels.

Read more
Community showcase
Piotr Plewa
Published Dec 27, 2017 in Bitbucket

Recipe: Deploying AWS Lambda functions with Bitbucket Pipelines

Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda&nbsp...

1,764 views 1 5
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you