The bitbucket-pipe-release pipe does not support an empty list of files to update

[oobug]

I am using version 5.1.0 of the Atlassian bitbucket-pipe-release within my own pipe repository. I am providing a version number manually and I do not want any of the built-in version number handling.

If I try to provide an empty string to the UPDATE_VERSION_IN_FILES argument, the pipe fails with the following output:

Traceback (most recent call last):
  File "/pipe.py", line 184, in <module>
    main()
  File "/pipe.py", line 180, in main
    release.run()
  File "/pipe.py", line 59, in run
    version = self.version_bump()
  File "/pipe.py", line 121, in version_bump
    f'{repo_slug}:[0-9]*\.[0-9]*\.[0-9]*(@sha256:[a-fA-F0-9]*)?') # noqa
  File "/pipe.py", line 37, in replace_content_by_pattern
    with open(filename) as f:
FileNotFoundError: [Errno 2] No such file or directory: ''

This issue is caused by an incorrect check on line 115 of pipe.py. The code will exit when the filenames_to_update variable is equal to "". However, the .split() function has already been applied to this variable, so it will never be equal to "", but would instead be equal to [""]. Please fix.

[Igor Stoyanov · Accepted solution]

@oobug hi. Thank you for investigating this bug.

We will notify you when new pipe version with fix will become available.

Regards, Igor

[oobug]

I have created a pull request with a fix for this issue: https://bitbucket.org/atlassian/bitbucket-pipe-release/pull-requests/16

[oobug]

This was ultimately fixed in PR https://bitbucket.org/atlassian/bitbucket-pipe-release/pull-requests/19, producing release 5.3.2.