Is there some way in Stash to say that I've completed reviewing the code?
There is the approve button, but that is only useful if you're happy with the code.
However, if you want to let the developer know that you've finished reviewing and that they can start implementing your changes, there is no way to do this, other than leaving a comment saying "Finished reviewing".
Otherwise, the developer will end up pushing up lots of tiny commits for each comment, when it's usually nicer to bundle the changes once the reviewer has finished.
I found 2 plugins that have source code available that could easily be used as the basis of a review complete plugin: https://marketplace.atlassian.com/plugins/com.atlassian.stash.plugin.stash-auto-unapprove-plugin#support https://marketplace.atlassian.com/plugins/com.palantir.stash.stash-disapprove-plugin Auto-unapprove button concept could be used to clear the "review complete" on new pull requests. And the disapprove-plugin to see how to add buttons to a pull request.
There isn't currently a feature like this, however there is an existing open feature suggestion to track this idea: https://jira.atlassian.com/browse/STASH-2999
You can add your vote, as votes are one factor we use when determining features to roadmap, and keep watch on that issue for any future updates.
This community is celebrating its one-year anniversary and Atlassian co-founder Mike Cannon-Brookes has all the feels.Read more
Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda ...
Connect with like-minded Atlassian users at free events near you!Find a group
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no AUG chapters near you at the moment.Start an AUG
You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs