I am trying to write a merge-check hook that will take the list of changed files from a pull request and run a system command on them, effectively for deployment. I only want to deal with the changed files as the repositories I will be dealing with have thousands of files in a single directory. I would just write a bash script, but need the configurability the Stash UI provides.
I've got a demo hook running with atlas-run, so I've got the very basics going. I know that, were I on the command line, I could run 'git diff --name-only master..pullrequest_branch' for a list of changed files, which I can copy into a temp directory with 'git cat-file', 'git show', etc. Right now my bottle neck is just getting access to the repository.
First of all, should I be using system calls for the above actions, or can I get this information using the built in git libraries?
Second, how do I get that information from my repository? Using the git library, I can probably use the hook's context directly, but if I am running the system calls, how do I get the directory from which I need to run these commands?
If you're writing a merge-check my advice would be to stick to the Stash API where possible. For normal operations like comparing revisions and getting the file contents we have already handled all the plumbing for you.
Jason has got some useful advice here. You will probably be interested in the HistoryService.getChanges() method, which is basically your 'git diff' command.
And I link to my plugin which does some/most of what you want here:
I know there's a fair amount of Java noise in there. :( I use cat-file to get the file size, but we have a ContentService.streamFile if you're just looking to do a 'git show'.
If you just want the repository directory you can get it from:
You'll then need to fork out to Git and parse the results yourself. As mentioned above, if you can navigate our Java API I would recommend sticking with what we have as it should (hopefully) make your life a little easier.
Let me know if you have any more specific questions or need help with your plugin/hook.
Right now I'm thinking the simplest solution is to get the repository directory and then fork to a script to do the actual heavy lifting. There is just too much Java noise to sift through for what I need, and I know exactly what git commands I need to run to get what I want.
I'm trying to call the getRepositoryDir() function you linked above, but get an error:
cannot find symbol symbol : method getRepositoryDir(com.atlassian.stash.repository.Repository)
I have added
to the top of my java file and I am just calling the function like so:
System.out.println("repo " + getRepositoryDir(context.getRepository()));
Any idea why I am getting that error?
I just realized that getRepositoryDir is a class function, so that is problem one. I tried creating an ApplicationPropertiesService, but get an error saying that the class is abstract and cannot be instantiated, and if I try to call ApplicationPropertiesService.getRepositoryDir(), I get an error saying that it cannot be referenced from a static context.
Is there an ApplicationPropertiesService object somewhere else that I should be calling this function on?
I decided to try a bit harder to use the API and made some progress, but it seems that the version of HistoryService's getChangesetBetween() that you are using is deprecated. I'm trying to update it to use a newer version, but am getting errors in my import lines. I made a new question for this problem here: https://answers.atlassian.com/questions/209860/cannot-find-symbol-class-changesetsbetweenrequest
Just realized that merge-check might not be the best choice. This deployment hook could potentially fire before other possibly blocking checks. The problem of doing a post-receive hook is that finding the list of changed files might be more challenging. If anyone has a solution to that, I'm all ears.
If you're deploying something I _definitely_ wouldn't do this as part of a merge check. They fire every time a user views a pull request page.
You should be able to do the deploy as part of post-receive hook and/or just listen specfiically for PullRequestMergedEvent which has a list of RefChange objects which you can then diff as you would in the merge-check. Does that make sense?
One last thing - I'm just wondering if this could be done as part of a normal build operation? Normally the Stash team (and Atlassian in general) would do deployments from a Bamboo plan when a branch (ie master) has changed. Bamboo 5.0 even has a new deployments feature.
This may not be possible in your scenario, depending on what configuration in Stash you're providing and how critical it is to the build scripts to know what changed in any given merge (that may be available to the plan, I'm not 100% sure).
As a project manager, I have discovered that different developers want to bring their previous branching method with them when they join the team. Some developers are used to performing individual wo...
Connect with like-minded Atlassian users at free events near you!Find a group
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no AUG chapters near you at the moment.Start an AUG
You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs