ScriptRunner Groovy script to require at least one approver from a list.

Hello all,

I'm wanting to have a merge check that requires at least one of the approvers to be in a list.

I tried something like this as a conditonal but for whatever reason it's not behaving like I expected.


def ops_team = ['Spongebob', 'Squidward', 'Patrick']
mergeRequest.pullRequest.reviewers.find {it.approved && it.user.name in ops_team}


Any ideas?

1 answer

1 votes

Sorry about the delay... if you use the plugin's tag you will get a faster response. I added it now.

The only problem with your code is that you need to call .veto on the mergeRequest to block it, as described in Working with Custom Merge Checks.

I rewrote your code as the following and it worked:

import com.atlassian.bitbucket.scm.pull.MergeRequest

def mergeRequest = mergeRequest as MergeRequest
def ops_team = ['Spongebob', 'Squidward', 'Patrick', 'admin']

def ok = mergeRequest.pullRequest.reviewers.any {it.approved && it.user.name in ops_team}

if (! ok) {
    mergeRequest.veto("Ops approval required", "Need at least one member of Ops to approve")
}

 

 

 

 

Thank you for the reply!

 

One shortcoming I noticed is that this way requires a member to listed as a reviewer, as opposed to being 'just' approver.

 

Would something like this work:

 

def ok = mergeRequest.pullRequest.approvers.any { it.user.name in ops_team}

 

 

Hi Matthew,

I'm not sure what your asking, a pull request just has reviewers which can approve it.

Can you explain a bit more how you would like the merge check to behave?

Thanks,
Adam 

Suggest an answer

Log in or Join to answer
Community showcase
Piotr Plewa
Published Dec 27, 2017 in Bitbucket

Recipe: Deploying AWS Lambda functions with Bitbucket Pipelines

Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda&nbsp...

651 views 0 4
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you
Atlassian Team Tour

Join us on the Team Tour

We're bringing product updates and pro tips on teamwork to ten cities around the world.

Save your spot