Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in
Celebration

Earn badges and make progress

You're on your way to the next level! Join the Kudos program to earn points and save your progress.

Deleted user Avatar
Deleted user

Level 1: Seed

25 / 150 points

Next: Root

Avatar

1 badge earned

Collect

Participate in fun challenges

Challenges come and go, but your rewards stay with you. Do more to earn more!

Challenges
Coins

Gift kudos to your peers

What goes around comes around! Share the love by gifting kudos to your peers.

Recognition
Ribbon

Rise up in the ranks

Keep earning points to reach the top of the leaderboard. It resets every quarter so you always have a chance!

Leaderboard

Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,461,799
Community Members
 
Community Events
176
Community Groups

Pull request comment disappearing

After a pull request is updated if a line contains a comment and that line is changed the comment disappears. 

Is that the normal behaviour?

1 answer

0 votes
Ana Retamal Atlassian Team Aug 23, 2017

Hi Luis, updates to a file in a pull request can cause comments to disappear. We attempt to put the comments back on the correct line however this is not always possible (for example when the line is removed from the file).

I don't know the particulars about your case, so I'm not able to tell  whether or not your comment should have been removed or not.

The Bitbucket team wrote a detailed description about this behaviour at Building inline comments for pull request and commits (see the "High Plains Drifter" section). This might help you understand how this issue is approached.

Lastly, are you using Bitbucket Cloud or Server? For Server, we have a feature request at BSERV-7534 You can vote for it or add your comments.

Hope this helps!

Ana

Hello Ana,

 

Thanks for the response. 

 

It's not the case. We are using at this moment Bitbucket Cloud for the first time and trying it. 

 

In this particular case, we made a commit modifying a line with a comment and it disappear. This commit the only thing that does is renaming a variable in the line so it's very strange.

 

Yes we read the documentation about the "Hight Plains Drifter" and we thought the comment wasn't going to be removed. 

jredmond Atlassian Team Aug 23, 2017

Generally, if the line changes, it's in response to the comment(s), so the PR diff view hides comments that are possibly obsolete.

Look for a number next to the "Side-by-side diff" button on a file's header, like the 2 in this screenshot; if you click that, then you should be able to see the hidden comments on that file.Screen Shot 2017-08-23 at 11.01.14 AM.png

Ah ok. That's the normal behaviour, the comment disappearing after a change on the line.

 

We though is a little hard to review the changes after the comment is gone. We need to open the box with the number "2" (on your example) a view what comment were made and in what lines to make sure the changes are fixed. Maybe we are using it wrong.

Thanks!

Do we have a way to visualize comments next to the last version of the code?

Like # people like this

@jredmond What about the case where a side-by-side diff is not allowed?

  1.  A new file is created
  2. Comments are added for a change
  3. Changes are made and added to the pull request (this step may be repeated)

In this case, it seems that the comments are hidden as obsolete in the Unified View, but since the file is considered new, the side-by-side diff is not allowed.

Could you make a way to see pull request diff at the state when was made the comment?  

 

Now pull request shows diff from latest code. In other words - diff from specific commit and code where we want to merge to.

 

Also the code where we want to merge to might change. So migth be not fully solvable. But still better.

And for that case maybe just add screenshots of the code and comments.

@jredmond , there is a button e.g. 17 prior comments 

image.png

But clicking on it doesn't do anything for me?

It's a normal Pull request created on https://bitbucket.org/ within a private repository

PR comments do disappear in Bitbucket cloud when a file with PR comments has its filename renamed.

Like Nikita likes this

When a file is renamed in the PR, the PR displays the contents of the file as all new even though nothing may have been changed at all in the file contents.

Like Nikita likes this
Nikita I'm New Here Sep 07, 2022

Hi, Atlassian Team!

When a file is renamed in the PR, the PR displays the contents of the file as all new even though nothing may have been changed at all in the file contents.

This creates a lot of problems for code review.

Do you consider this acceptable behavior? Are there any moves in this direction?

Suggest an answer

Log in or Sign up to answer
TAGS

Atlassian Community Events