Pull-Request fetures

hello, we are trying to utilizing Pull-Request features for code review process, what we want to accomplish is to:

1. developers made the code change and create Pull-request

2. reviewers will approve/un-approve the Pull-request

3. only after pull-request is approved, it will be allowed to be merged.

but as far as I understand, pull-request is loosely designed and have the following problem:

1. it allows observer to approve the code as participant

2. it allow contributor to merge the pull-request even before the code is approved

Can you help with the above issue? Thanks a lot!

2 answers

1 accepted

Hey Simon,

Thank you for the suggestions.

1. it allows observer to approve the code as participant

You can use branch permissions to control who can push/delete a branch.

But, I think you might be after these new features:
https://jira.atlassian.com/browse/STASH-3140
https://jira.atlassian.com/browse/STASH-2999

Feel free to leave feedback on the JIRA tickets above and vote for the issues, if you'd like them implemented.

Thanks,
Ajay.

Hey Simon,

Thank you for the suggestions.

1. it allows observer to approve the code as participant

You can use branch permissions to control who can push/delete a branch.

But, I think you might be after these new features:
https://jira.atlassian.com/browse/STASH-3140
https://jira.atlassian.com/browse/STASH-2999

Feel free to leave feedback on the JIRA tickets above and vote for the issues, if you'd like them implemented.

Thanks,
Ajay.

Suggest an answer

Log in or Sign up to answer
Atlassian Community Anniversary

Happy Anniversary, Atlassian Community!

This community is celebrating its one-year anniversary and Atlassian co-founder Mike Cannon-Brookes has all the feels.

Read more
Community showcase
Piotr Plewa
Published Dec 27, 2017 in Bitbucket

Recipe: Deploying AWS Lambda functions with Bitbucket Pipelines

Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda&nbsp...

2,030 views 1 5
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you