Pull-Request fetures

hello, we are trying to utilizing Pull-Request features for code review process, what we want to accomplish is to:

1. developers made the code change and create Pull-request

2. reviewers will approve/un-approve the Pull-request

3. only after pull-request is approved, it will be allowed to be merged.

but as far as I understand, pull-request is loosely designed and have the following problem:

1. it allows observer to approve the code as participant

2. it allow contributor to merge the pull-request even before the code is approved

Can you help with the above issue? Thanks a lot!

2 answers

1 accepted

Hey Simon,

Thank you for the suggestions.

1. it allows observer to approve the code as participant

You can use branch permissions to control who can push/delete a branch.

But, I think you might be after these new features:
https://jira.atlassian.com/browse/STASH-3140
https://jira.atlassian.com/browse/STASH-2999

Feel free to leave feedback on the JIRA tickets above and vote for the issues, if you'd like them implemented.

Thanks,
Ajay.

Hey Simon,

Thank you for the suggestions.

1. it allows observer to approve the code as participant

You can use branch permissions to control who can push/delete a branch.

But, I think you might be after these new features:
https://jira.atlassian.com/browse/STASH-3140
https://jira.atlassian.com/browse/STASH-2999

Feel free to leave feedback on the JIRA tickets above and vote for the issues, if you'd like them implemented.

Thanks,
Ajay.

Suggest an answer

Log in or Sign up to answer
How to earn badges on the Atlassian Community

How to earn badges on the Atlassian Community

Badges are a great way to show off community activity, whether you’re a newbie or a Champion.

Learn more
Community showcase
Posted Jun 12, 2018 in Bitbucket

Do you use any Atlassian products for your personal projects?

After spinning my wheels trying to get organized enough to write a book for National Novel Writing Month (NaNoWriMo) I took my affinity for Atlassian products from my work life and decided to tr...

28,577 views 26 12
Join discussion

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you