Merge Approval - Can I approve my own pull requests?

Currently, our pull request configurations are set to have 1 minimum approval prior to merging into a branch. Is it possible to approve my own pull request, or does an independent reviewer need to approve prior to merging into the branch?

3 answers

1 accepted

2 votes
Accepted answer

Dear Brett,

I am afraid that this is not possible to do it yourself, it has been adressed in the past;

https://jira.atlassian.com/browse/BSERV-4462

https://jira.atlassian.com/browse/BSERV-9544

The general response was;

Thanks for the suggestion! Unfortunately this isn't something that we're likely to add to Bitbucket in the near future.If such a request persists, we'll be sure to reconsider.

Friendly Regards,

Jeremy Mooiman

Thank you for confirming, Jeremy!

Jeremy Atlassian Community Champion Aug 07, 2017

Dear Brett,

No worries! You could still create a ticket with Atlassian and reference to the documentation that other people have requested it. Chance is that they will start working on the feature.

Friendly Regards,

Jeremy

That sucks. The blocking functionality could be achieved by having 2 reviewers, It just feels stupid to hard limit that way. There are scenarios where you just want the approve to be "Yeah, I've double checked my code". For those branches you want independent reviews, you could use 2 reviewers. Even better would actually be a setting on groups that allows that particular group (for example senior developers) to approve their own pulls. Right now I can only achieve this through either disabling approve *or* adding that user to a group that can push directly to the branch.

That sort of defeats the purpose of peer review and merge checks if the requester can approve his/her own pull request.  I for one, wouldn't want to see this ever implemented.

Like 1 person likes this
Mike West I'm New Here Aug 02, 2018

if developer_cnt > 1:

   print "You are right Carl"

else:

   print "I could use this"

 

As a single developer it's easy enough for me to merge a development branch to an integration or master branch on my local pc and push it. No problem. But I would prefer to go through the pull request process to force myself to check my own work; and to have a record on Bit Bucket

0 votes

Blah blah blah. There are lots of reasons why you shouldn't review your own pull requests, yes. But that's not point. There are times when I need to merge something and I just need to get the job done. 

Suggest an answer

Log in or Sign up to answer
Community showcase
Published Nov 06, 2018 in Bitbucket

Upgrade Best Practices

Hello! My name is Mark Askew and I am a Premier Support Engineer for products Bitbucket Server/Data Center, Fisheye & Crucible. Today, I want to bring the discussion that Jennifer, Matt, and ...

426 views 6 9
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you