Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in
Celebration

Earn badges and make progress

You're on your way to the next level! Join the Kudos program to earn points and save your progress.

Deleted user Avatar
Deleted user

Level 1: Seed

25 / 150 points

Next: Root

Avatar

1 badge earned

Collect

Participate in fun challenges

Challenges come and go, but your rewards stay with you. Do more to earn more!

Challenges
Coins

Gift kudos to your peers

What goes around comes around! Share the love by gifting kudos to your peers.

Recognition
Ribbon

Rise up in the ranks

Keep earning points to reach the top of the leaderboard. It resets every quarter so you always have a chance!

Leaderboard

Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,456,998
Community Members
 
Community Events
176
Community Groups

Is there a way to have a rework state that isn't a pull reject but isn't an accept yet?

Edited

Pull request comments ask for a change that takes a bit.  Every reviewer sees the push notifications getting the suggestion addressed and none know if it is ready to re-review.  Email is sent to hold off until I am done, etc..

 

Is there a way to move a pull request to a rework state until ready?

 

1 answer

0 votes

Hi @David Goldman ,

"Change Requested" status should help you on that.

Please, take a look to the following article https://bitbucket.org/blog/a-new-status-for-pull-requests-in-bitbucket-cloud-changes-requested

Hope this helps,

Fabio

We have tasks assigned when there are expectations in a pull before merging. 
"Change requested" is not all inclusive.  There are questions or comments that require response even if it isn't a requested code change.

If the requested changes are addressed, it doesn't mean all the questions and comments have been responded to or that the overall changes are complete beyond the specific change requested.

If the reviewers put a task or change request on every comment then this would work.  They don't because that isn't obviously a requirement.

It would still benefit to have an explicit state for reworking.

Also, in our particular setup, there is no declined, only rejected and pulls cannot be reopened.  A new one is needed and the comment history is in the old pr.  Awkward.

Suggest an answer

Log in or Sign up to answer
TAGS

Atlassian Community Events