I've been using Gerrit before my team moved to Stash.
Stash is much more user friendly, but I miss some features of Gerrit that are great.
PR 1: implement server side logic for a given use case
PR 2: implement client side logic for the same use case
PR 2 needs the code of PR 1, so it includes all the commits of PR 1
With the current status of Stash (we use 3.4 for now), the diff view of PR 2 shows diff against master, and it cannot be properly reviewed until PR 1 is merged, otherwise, you see commits of both PR 1 and PR 2 in the diff view of PR 2.
In Gerrit, you see only the diff of PR 2, the only restriction is that you cannot merge it before PR 1 is merged (which is fine).
Any plan to achieve this with Stash ?
Minimalist solution would be a to be able to choose the reference branch/commit for the diff view.
Best would be to show the diff against the other PR.
In Gerrit, there is the notion of patch set, which is a 'version' of the pull request. In the diff view, it is possible to select against what you diff. It can be the base of the PR, or any previous patch set. It makes it super easy to see what was updated.
Solution to implement that in Stash would be either:
Is that something you would consider ?
Thanks for reading and for developing this great product!
I'd like to add that we would also like this feature. We're currently using Crucible and Fisheye to do code reviews for pull requests, and Crucible has this feature by virtue of the commit range slider, which is insanely useful, as I can decide how big or small my diff is going to be. You can kind of get this in Stash by going into the diff of subsequent individual commits, but it's not the same (and obviously you can't see multiple commits at once this way).
+1 on this There needs to be a way to view the changes introduced by the pull request without having to click to each file In github on the files changed tab you can scroll through all the changes without having to click on a file to see just its changes. This is much more useful because very often you can scan the changes and detect where you need to focus. This functionality is more important when you have pull requests that contain small focused commits vs the 1 commit that changes 50 files and has a commit message of Fixed bug #XXXX
Badges are a great way to show off community activity, whether you’re a newbie or a Champion.Learn more
After spinning my wheels trying to get organized enough to write a book for National Novel Writing Month (NaNoWriMo) I took my affinity for Atlassian products from my work life and decided to tr...
Connect with like-minded Atlassian users at free events near you!Find a group
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no AUG chapters near you at the moment.Start an AUG
You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs