Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in
Deleted user
0 / 0 points
Next:
badges earned

Your Points Tracker
Challenges
Leaderboard
  • Global
  • Feed

Badge for your thoughts?

You're enrolled in our new beta rewards program. Join our group to get the inside scoop and share your feedback.

Join group
Recognition
Give the gift of kudos
You have 0 kudos available to give
Who do you want to recognize?
Why do you want to recognize them?
Kudos
Great job appreciating your peers!
Check back soon to give more kudos.

Past Kudos Given
No kudos given
You haven't given any kudos yet. Share the love above and you'll see it here.

It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Are code suggestions broken in Bitbucket 7.4? Edited

Developers have started complaining that the newly introduced suggestions feature doesn't work anymore, and everyone gets the following error when trying to use the suggestion.

 

"We can't apply this suggestion to the source branch. You'll need to make this change manually."

 

(which is less than helpful, it's a very wordy "something went wrong")

Untitled.png

1 answer

1 vote
Bryan Turner Atlassian Team Aug 10, 2020

@markgillespien

I'd recommend opening a support request for this. Our automated test suite for suggestions is all green, and we're unable to reproduce any issues with suggestions internally. If you've recently upgraded, that may be related. That sort of information is better exchanged on a support ticket, rather than here on Community. Once we resolve your issue we can update this question with any relevant details in case someone else happens to hit whatever issue you're hitting.

Best regards,
Bryan Turner
Atlassian Bitbucket

Sadly our SEN expired 2 weeks ago, and we aren't renewing,


I did try updating GIT to latest supported, and rebooting the server, but it's not helped.  

Bryan Turner Atlassian Team Aug 11, 2020

I'm interested in helping, but realistically without logs and additional information about your instance there's not a lot I can do. If suggestions fail to apply in a way that shows that popup, there should be an error/stack trace in the logs on the server with more details about the failure.

Your title indicates you're on 7.4 now, but have you recently upgraded? If so, what version did you start out with? Something 6.x, perhaps? When this issue happens for developers, is it in pull requests that were open before the upgrade, or does it also happen in new pull requests created after? (Given 7.4 was only released recently, it seems like there must have been some upgrade involved.)

Unfortunately, here on this public issue isn't a great place to exchange details like this. If you want to ping me directly via email, I'm happy to see if I can get you sorted.

Best regards,
Bryan Turner
Atlassian Bitbucket

Like mark_gillespie likes this

We track versions quite closely, as there are always nice additions (thanks!!), so we came from 7.3 (which did work to my knowledge).

I did run the system log inspector but it didn't come back with any errors, I will take a look the logs and see if I can see anything.

 

In my mind, there are two possible things that we did within the timeframe it started that could be causing this:

 

  • Upgrade to 7.4
  • Change Default Merge Strategy to Squash on Merge.

 

I don't think it's the later, as we have some other projects that have always been squash on merge, and they didn't have any trouble.  The problem for us appears across all repos and projects.

 

Looking at the logs, I am seeing alot of these:

 

2020-08-11 09:37:51,235 INFO [drift:thread-4] c.a.s.i.p.c.d.DriftCommentUpdateProcessor 572:2495@11: Comment 78696 is already in the current diff (617864c71166d55793f43439443f5bebfb2f79bb, d2f70358852ac9a3574cf5cf0590d4a787375feb) and will not be drifted
2020-08-11 09:37:51,235 INFO [drift:thread-4] c.a.s.i.p.c.d.DriftCommentUpdateProcessor 572:2495@11: Comment 78698 is already in the current diff (617864c71166d55793f43439443f5bebfb2f79bb, d2f70358852ac9a3574cf5cf0590d4a787375feb) and will not be drifted
2020-08-11 09:37:51,235 INFO [drift:thread-4] c.a.s.i.p.c.d.DriftCommentUpdateProcessor 572:2495@11: Comment 78707 is already in the current diff (617864c71166d55793f43439443f5bebfb2f79bb, d2f70358852ac9a3574cf5cf0590d4a787375feb) and will not be drifted
2020-08-11 09:37:51,235 INFO [drift:thread-4] c.a.s.i.p.c.d.DriftCommentUpdateProcessor 572:2495@11: Comment 78703 is already in the current diff (617864c71166d55793f43439443f5bebfb2f79bb, d2f70358852ac9a3574cf5cf0590d4a787375feb) and will not be drifted
2020-08-11 09:37:51,235 INFO [drift:thread-4] c.a.s.i.p.c.d.DriftCommentUpdateProcessor 572:2495@11: Comment 78702 is already in the current diff (617864c71166d55793f43439443f5bebfb2f79bb, d2f70358852ac9a3574cf5cf0590d4a787375feb) and will not be drifted
2020-08-11 09:37:51,235 INFO [drift:thread-4] c.a.s.i.p.c.d.DriftCommentUpdateProcessor 572:2495@11: Comments have already been drifted (617864c71166d55793f43439443f5bebfb2f79bb, d2f70358852ac9a3574cf5cf0590d4a787375feb) when processing 1 drift request(s):

I figured out the problem.  It's related to 3rd party plugin YACC , and the latest version (1.25).  Reverting to the previous version (1.24) and it's working as expected.

The changes in that version were related to checking service accounts.  Unticking the setting in YACC to exclude service accounts still didn't fix this, only downgrading did.

 

Thanks for your offer of help in getting to the bottom of things.

 

Raised a bug with the vendor.

Bryan Turner Atlassian Team Aug 11, 2020

I'm glad you were able to get to the bottom of it.

Just as an FYI, the drift messages are nothing to be concerned about (which is why they're logged at INFO level instead of something more serious); they just indicate that the system went to do some background housekeeping for a given pull request and found that it was already done.

Best regards,
Bryan Turner
Atlassian Bitbucket

Hi Bryan.

 

I'm one of maintainer of mentioned plugin (YACC), which uses repository / global hooks to control the contents of commit message and reject changes if message is not valid.

In version 1.25 we have added checking of changes made from Bitbucket UI and I found that:

  1. Bitbucket 7.4.0 Apply suggestion feature produces FILE_EDIT hook event, which fires hook and displays error when hook vetoes this change, but it doesn't display reject details, which doesn't allow developer to understand the reasons of reject:

    Screenshot from 2020-08-13 16-52-41.png

    If you edit file from source viewer, details message is displayed properly:

     Screenshot from 2020-08-13 16-36-43.png

    This doesn't seem convenient, so it would be great to see similar message when you try to apply suggestion from pull request comments.

  2. Moreover, if applying suggestion is rejected once, it is cached then and it's not possible to repeat an attempt applying it. Again, committing change from source editor allows to edit and commit change if it was rejected before - would be nice to have a consistence here too.

 

Thanks.

Like Maciej Adamczak likes this

Thanks for such a good investigation @Alexey Remnev ! I will create a bug ticket in our tracker and forward all of your findings there.

https://jira.atlassian.com/browse/BSERV-12528

Maciej

Bitbucket Developer

@Alexey Remnev Where can we get the v1.25 (or v1.26) YACC? It seems they don't exist in the Marketplace anymore.

@Maciej Adamczak - My team is struggling with this exact issue. I see it is in your long term backog since August and updated in October. Do you have any updates as to when this might be fixed? Thanks!

@Tara English-Sweeney I would recommend contacting the support team and also commenting on the mentioned Jira issue: https://jira.atlassian.com/browse/BSERV-12528

Suggest an answer

Log in or Sign up to answer
TAGS
Community showcase
Published in Bitbucket Pipelines

Bitbucket Pipelines Runners is now in open beta

We are excited to announce the open beta program for self-hosted runners. Bitbucket Pipelines Runners is available to everyone. Please try it and let us know your feedback. If you have any issue...

670 views 15 9
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you