Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in
Celebration

Earn badges and make progress

You're on your way to the next level! Join the Kudos program to earn points and save your progress.

Deleted user Avatar
Deleted user

Level 1: Seed

25 / 150 points

Next: Root

Avatar

1 badge earned

Collect

Participate in fun challenges

Challenges come and go, but your rewards stay with you. Do more to earn more!

Challenges
Coins

Gift kudos to your peers

What goes around comes around! Share the love by gifting kudos to your peers.

Recognition
Ribbon

Rise up in the ranks

Keep earning points to reach the top of the leaderboard. It resets every quarter so you always have a chance!

Leaderboard

Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,456,968
Community Members
 
Community Events
176
Community Groups

Approve PR button disappears after PR gets merged

I've recently noticed that it's not possible anymore to APPROVE an already merged PR.

Why is that happening?

Previously it was possible to provide feedback even once the PR was merged.

For us, sometimes we merge some PRs and feedback reviews are happening after, for instance, when we're in a hurry for a hotfix and we do need to deploy that hotfix quickly into production, however reviewers are doing the reviews after to be sure the new code is correct.

Is there any possibility to be able to get back the big green Approve button even for already merged PRs?

I reviewed all the config at repo level and project level and I could not find any option for that.

Thanks in advance.

3 answers

1 accepted

1 vote
Answer accepted
Patrik S Atlassian Team Jan 19, 2023

Hello @moises_cobrowser ,

I see you have also opened a support ticket with us. Just sharing here as well that we have created a feature request to allow Pull Requests to be approved after they were merged, which can be accessed with the link below : 

For users who are interested in that feature, we suggest adding your vote there, since this helps both developers and product managers to understand the interest. Also, make sure to add yourself as a watcher in case you want to receive first-hand updates from that ticket. Please note that all features are implemented with this policy in mind.

Thank you, @moises_cobrowser !

Patrik S

Patrik, one thing that wasn't addressed was the fact that many of us previously saw this functionality working, I hadn't seen anything about why it was pulled out, and now it's being turned into a feature request. So my understanding of this would be that the engineering team corrected what they felt was a bug and the strategy team is looking at future work to make this a feature? 

1 vote
Trace I'm New Here Jan 19, 2023

I agree the approve-after-merge feature is highly used in our organization. This will probably be the final nail for us since private repos are common elsewhere as well. Hope the approve button can be readded quickly. 

For now we're using comments for approvals but this will not last too long. 

Hi @moises_cobrowser :

I think as per your suggestion, it won't be useful to add approve button for already merged PRs. This is the way code flow is going on in Bitbucket repository, if you can add merge check policy like Check for at least number of approvals for every PRs : https://support.atlassian.com/bitbucket-cloud/docs/suggest-or-require-checks-before-a-merge/

Then it will not merge those PRS before getting any approvals.

OR

 

If you want this request then please contact with Atlassian Support Team

Link: https://support.atlassian.com/

 

Regards,

Mahesh Shinde

 

Hi Mahesh, 

I think as per your suggestion, it won't be useful to add approve button for already merged PRs.

I already explained one of the reasons of providing feedback after the PR is merged.

We already have in place checks before PR approval, but we can't enforce them. 

Imagine we're in a hurry for merging something that needs to fix something urgently on production, only one developer on support duty call, then we need to wait till the next day to have one approval to be able to deploy a hotfix to production.

That's not ok, not at all.

However since we're a big team and we have multiple reviewers involved, the Approve button has been really helping us during the PR review process even if the PR was already merged to know that all involved people gave their approval.

Now that's no longer possible, and makes no sense to me the change you have introduced.

Suggest an answer

Log in or Sign up to answer
DEPLOYMENT TYPE
CLOUD
PERMISSIONS LEVEL
Site Admin
TAGS

Atlassian Community Events