Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in
Celebration

Earn badges and make progress

You're on your way to the next level! Join the Kudos program to earn points and save your progress.

Deleted user Avatar
Deleted user

Level 1: Seed

25 / 150 points

Next: Root

Avatar

1 badge earned

Collect

Participate in fun challenges

Challenges come and go, but your rewards stay with you. Do more to earn more!

Challenges
Coins

Gift kudos to your peers

What goes around comes around! Share the love by gifting kudos to your peers.

Recognition
Ribbon

Rise up in the ranks

Keep earning points to reach the top of the leaderboard. It resets every quarter so you always have a chance!

Leaderboard

Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,560,643
Community Members
 
Community Events
185
Community Groups

Extended Code Review functionality

Paul Chown
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
Mar 29, 2023

I was thinking this morning about code reviews. We often have larger refactorings that touch lots of files, often with trivial changes, and it's hard to find time to go through the whole thing in one sitting without being interrupted. After you've been interrupted, it's also hard to know where you were.

How about adding an additional space for code reviews. For simple changes it's OK to just approve directly and comment directly in the PR (as now), but for larger PRs it would be really nice to be able to say 'start code review' and then enter a private space where I can:

  • mark files as 'unreviewed', 'approved', or tag with custom labels ('Cool!', 'Huh?') and colours
  • filter the view by label (show all, only show unreviewed files, only show 'Huh?' files)
  • comment/annotate locally without notifying other users

The fact that a code review has been started would also show up in the PR, so if someone has already started the review of a large PR other reviewers can see that and avoid duplicate effort.

The state can be defined by file and head revision, so if the PR is updated then modified files revert to 'unreviewed'.

On completion, any open comments can be transferred to the main PR and the review status updated appropriately.

It seems like this should fit with a lot of the existing functionality and interface components, and would help enormously to deal with big PRs as 'trivial' changes can be quickly filtered out, progress is persisted through interruptions, and duplicate work is avoided.

0 comments

Comment

Log in or Sign up to comment
TAGS
AUG Leaders

Atlassian Community Events