Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Add yourself as reviewer to a pull request

Job Mulder
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
November 13, 2023

First, I have seen the standard reply to this:

"You cannot add yourself as a reviewer to a pull request you create. As the person who initiated the pull request, it is implied that you have seen the code/reviewed already. You are a "reviewer" in that you wouldn't have initiated the pull request if you did not feel as though the work was complete. Does that make sense?"

And no, it does not make sense. Let me explain.

For a project I have a small team of 2 people (Alice and Bob). They review each other's code.

Now these are the situations.

Case 1: Alice makes a change, creates a pull request and asks Bob to review. Bob reviews, finds some minor issue, FIXES it himself and then asks Alice to review the changed code. This requires Alice to be a reviewer on her own pull request.

Case 2: Alice and Bob work together on some feature branch, they both agree that they're done, because it works. They DO want to both review the full code, since they've mostly seen their own part. One of them will start the pull request and should be able to add them both as the reviewers.

 

So, please add the option to add yourself as a reviewer. If necessary, you can add an optional rule that says that you cannot be the ONLY reviewer on your own work.

1 comment

Voom Vermon
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
November 15, 2023

What's with all the please statements that folks keep pleading for?

Job Mulder
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
November 16, 2023

It's just being polite. It shows that I would appreciate if the developers would add/fix this, but I understand that they may have other priorities.

'Please add the option...' puts people in a much more helpful state of mind than 'Fix my problem now or else...', which ultimately will help me get my way. Being polite is usually beneficial for both parties.

Comment

Log in or Sign up to comment
TAGS
AUG Leaders

Atlassian Community Events