It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Code Review Process with Bamboo Crucible and Stash

Jon L Oct 13, 2012

We want to implement code reviews at our company, but are not quite sure how the process would work. We currently use JIRA / Fisheye, Jenkins and svn, but would like to switch to Git.

We were considering using Bamboo (instead of Jenkins), Stash, Crucible, and (possibly) Clover and Greenhopper. Do these products work together well? We're most concerned about Stash, Crucible, and Bamboo getting along.

Our basic idea would be to basically input a build (& test) + review before the automatic Stash merge. Is this possible to do? Are we approaching this the wrong way?

Thanks!

2 answers

1 accepted

0 votes
Answer accepted

You are certainly approaching this the right way :)

Bamboo detects new branches, creates builds for each branch, merges changes from master into the current branch and runs the tests against the result (you can optionally push back to master if the tests pass). Take a read of this blog that shows you how to get it all working.

Jon L Oct 15, 2012

Is it possible to do a code review in the middle of there though? That's where we're a bit stuck...nothing seems to mention integration with Crucible.

If you are using Stash, you can use Pull Requests to do the code review. Take a look at our release notes for more details.

https://confluence.atlassian.com/display/STASH/Stash+1.3+release+notes

The Stash team uses story branches and creates Pull Requests for reviewes. Although builds are run, they are currently not integrated into Stash. We will post a more detailed blog post about our own development process in the coming week.

0 votes
Semyon Vadishev Dec 01, 2012

My reply isn't strictly relevant to the question, so I put it as a comment here.

As you are switching from Subversion to Git, consider using SVN Importer Plugin for Stash to migrate the project's history. The plugin is Free; it's built upon SubGit, so it has the highest fidelity of translation among all the converters available. For more details refer to the official site or contact us at support@subgit.com.

Suggest an answer

Log in or Sign up to answer
This widget could not be displayed.
This widget could not be displayed.
Community showcase
Published in Jira

Here’s what we’re doing to make Jira Cloud faster

Hello Community 🤗 I’m Nikhil, a Product Manager on the Jira Cloud team working on performance improvements. Performance is an ongoing journey and we continue to invest heavily in it. We under...

103 views 0 16
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you