Calling WebWork Action function with parameters from velocity template

Hello. Im stuck with a strange problem.

I have a webwork module with an action class and velocity view. I can access action class methods from velocity template with $action.getIssueTypes(). This works fine until i need to pass parameters to the method. So when i use

$action.findTransitionsByIssueTypeId($issueTypeId)

it does not call the method, but instead prints the above instruction as text on the page. I have also tried

${action.findTransitionsByIssueTypeId($issueTypeId)}

${action.findTransitionsByIssueTypeId(${issueTypeId})}

$action.findTransitionsByIssueTypeId(${issueTypeId})

${action.findTransitionsByIssueTypeId(1)}

none of above works. As soon i have anything inside parameters bracket, it seems to be treaten as simple text by velocity.

i am sure that findTransitionsByIssueTypeId is working properly. It passes the tests. I am also sure, that there is an entry with id 1.

This is what i have

atlassian-plugin.xml
----------------------------

<webwork1 key="transitions-management-webwork" name="Transitions Management Webwork"
		i18n-name-key="create-and-link.components.transitions-management-webwork.name">
		<description key="create-and-link.components.transitions-management-webwork.description">The Successor Transition Management</description>
		<actions>
			<action
				name="com.bssnsoftware.jira.plugin.createandlink.actions.EditTransitionAction"
				alias="EditTransition">
				<view name="input">/views/edittransition/edit.vm</view>
			</action>
			<action
				name="com.bssnsoftware.jira.plugin.createandlink.actions.ManageTransitionsAction"
				alias="ManageTransitions">
				<view name="success">/views/managetransitions/view.vm</view>
			</action>
		</actions>
</webwork1>

ManageTransitionsAction.java

public class ManageTransitionsAction extends JiraWebActionSupport {

	private static final long serialVersionUID = -2086781953876101793L;
	@SuppressWarnings("unused")
	private static final Logger log = LoggerFactory.getLogger(EditTransitionAction.class);

	private final IssueTypeManager issueTypeManager;
	private final TransitionService transitionService;

	/* Constructor */
	public ManageTransitionsAction(final IssueTypeManager issueTypeManager, final TransitionService transitionService) {
		super();
		this.issueTypeManager = issueTypeManager;
		this.transitionService = transitionService;
	}

	@Override
	public String execute() throws Exception {

		return super.execute(); // returns SUCCESS
	}

	public Collection<IssueType> getIssueTypes() {
		return issueTypeManager.getIssueTypes();

	}

	public Collection<Transition> findTransitionsByIssueTypeId(final String issueTypeId) {
		Collection<Transition> transitions;
		final Long id = Long.valueOf(issueTypeId);

		transitions = transitionService.findTransitionByIssueTypeId(id);
		log.info("###" + transitions.size());
		return transitions;
	}

}


view.vm


#enable_html_escaping() ${webResourceManager.requireResourcesForContext("com.bssnsoftware.jira.create-and-link-plugin")} <h1>$action.getText('create-and-link.view.header')</h1> <table class="aui"> <thead> <tr > <th class="headrow" >Issue Type</th> <th>Transitions</th> </tr> </thead> #foreach($issueType in $action.getIssueTypes()) <tr> <td class="issuetype-column"><img src="$!{issueType.getCompleteIconUrl()}" /> $!{issueType.getName()}</td> <td class="transitions-column"> <span>${action.findTransitionsByIssueTypeId($issueType.getId())}</span> </td> </tr> #end </table> <a class="button aui-button" href="${req.contextPath}/secure/EditTransition!default.jspa" id="edit-transition-link">$action.getText('create-and-link.view.create-transition')</a> </div>

output

output

as you can see, calling $action.getIssueTypes() without parameters works fine. $action.findTransitionsByIssueTypeId($issueTypeId) does not get processed.
out of my disperation i have changed the signature of findTransitionsByIssueTypeId() to take no parameters and instead use a hardcoded id. So the call $action.findTransitionsByIssueTypeId() works.
When i touch the parameters, it does not.

Any ideas?

1 answer

1 accepted

I've found a work around. Passing parameters as Strings and converting them to proper representation (Long in my case) seems to work.

example: $action.findTransitionsByIssueTypeId("$issueTypeId")

and in action

Long issueTypeId = Long.valueOf(issueTypeIdString);

Suggest an answer

Log in or Sign up to answer
Atlassian Community Anniversary

Happy Anniversary, Atlassian Community!

This community is celebrating its one-year anniversary and Atlassian co-founder Mike Cannon-Brookes has all the feels.

Read more
Community showcase
Teagan Harbridge
Published Apr 18, 2018 in Agile

Top 10 Insights from the 12th Annual State of Agile Report

...challenges organisation’s experience in their efforts to adopt and scale agile.   Many people associate agility with complete flexibility. And that’s not necessarily true, as demonstrated by this finding....

314 views 1 3
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you