I'm have a listener for Issue Create where I am generating a unique staff id. It looks through all of the issues to find the most recent id and then increments it by one. I then update the issue. This is fine unless two updates happen at once and then I get a race condition and duplicate staff ids. I've tried using the Synchronized directive, but I'm still getting dups. I'd appreciate any advice if there is something obvious that I'm doing wrong. Thanks for any help.
public class StaffId {
@Synchronized
public static void getNewStaffId(ApplicationUser user, Query query, CustomField staffIdField, Issue currentIssue, SearchService searchService, IssueService issueService) {
def changeHolder = new DefaultIssueChangeHolder()
SearchResults results = searchService.search(user, query, PagerFilter.getUnlimitedFilter())
int num=0
int maxStaffIdNumber = 0
for(Issue documentIssue: results.getIssues()) {
num = documentIssue.getCustomFieldValue(staffIdField) as Integer
if (num > maxStaffIdNumber) {
maxStaffIdNumber=num
}
}
def newStaffIdNumber = ++maxStaffIdNumber as Double
staffIdField.updateValue(null, currentIssue, new ModifiedValue(currentIssue.getCustomFieldValue(staffIdField), newStaffIdNumber), changeHolder);
def update = issueService.validateUpdate(user, currentIssue.getId(), issueService.newIssueInputParameters())
if (update.isValid()) {
issueService.update(user, update)
}
}
}
