Cant upload file for pre-commit review (crucible)

[Rahul Aich [Nagra]]

Hi

I created a patch file from our perforce repository,

I now want to perform a pre-commit review on the patch file; when i try to load the file using pre-commit reviews option, it fails and gives me this error

How do i proceed from here? I tried several encoding but it is still the same.

My patch file is named patch.txt

No files found in patch. If it is not a valid patch file, upload it as an attachment.

Rahul

[lpater · Accepted solution]

Hi Rahul,

how are you creating the patch file?

For Perforce you should be using:

Crucible 3.3.1 or earlier: p4 diff -dcu > patch.txt

Crucible 3.3.2 or later: p4 -z tag diff -du > patch.txt

See https://confluence.atlassian.com/display/CRUCIBLE/Creating+patch+files+for+pre-commit+reviewsfor more details