"Suggest a Change" feature circumvents approval restrictions

Justin Rodante
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
August 20, 2021

It's pretty common compliance practice to prevent people from approving their own PRs, this is by default how bitbucket PRs work.   In that same vein, it's important for change management and compliance controls that all changes are approved by someone else.

 

By using the in-line "Suggest a change" feature, someone with write access can suggest an in-line code change on someone else's PR, approve that change themselves (?!), then approve the PR, and finnaly merge that PR.  That effectively allows them to add un-reviewed/tested code to a PR, and merge it.

Is there a way to disallow

  •  Suggesters from approving their own suggestion
  • Approving a PR if your user has authored ANY commit to the PR
  • or just disable the "suggest a change" feature if we can't do the above

0 answers

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events