Try out the new Bitbucket Cloud pull request experience today!

Viewing page 10 of 13

302 answers

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
March 6, 2019

Thanks for the screenshots @Manish Maharjan! I understand what you are referring to, now.

When you said file list, I thought you were referring to the (new) file tree (which you can view by clicking on the "141 files" card in the right sidebar), not the list of diffs itself.

But the good news is that we do plan to add the lines changed and comment count info to the diff headers (and the file tree), and we need to make the paths expandable, too.

Thanks again!

0 votes
Manish Maharjan March 6, 2019

Hi @Alastair Wilkes ,

 

Thanks for your response and acknowledging feedback seriously. Here i have attached screenshot that i meant by file list. 

Left side is the new Pull Request experience and Right hand side is Old Pull Request experience. 

 

This is just an example where about 141 files has been modified. So From right hand side, features like

- Showing number of lines that has been added/deleted

- Showing comments head icons displaying which files has been changed and how many comments 

-Displaying all these file list hierarchy in the beginning of the Pull request like in right hand side would have been very much beneficial

However, currently in the left side we are unable to see full file path if it is longer. Middle file path is being replaced with multiple dots. This creates a situation where we need to manually open the file and see the full path whenever it is needed. 

Therefore, we would say that we are missing these features and would have been valuable if these features were also ported to the newer version so that users could get nice experience. :) 

Other than that at least we have found new Pull request experience is good. 

Thank you  

Screenshot 2019-03-06 at 17.39.50.png

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
March 6, 2019

Hi @Manish Maharjan 

Thanks for your reply! I have a couple of clarifying questions:

Can you elaborate on what makes the old file list more skimmable than the new file tree? Is it the lack of the full file paths? The indentation?

Or is the UX issue that the file tree is in the sidebar and not in the center column? If so, why?

Sorry for the extra questions, but it's really helpful for us to understand the issues! We introduced the file tree in the sidebar to make it easier to navigate between files in the pull request, but we want to make sure it's as useful as the old list too.

FYI - we just added support for more than 100 files in the file tree, so perhaps that helps. And we'll look into adding a "back to top" button. :)

Alastair

0 votes
Manish Maharjan March 6, 2019

@Jiri Hana , That's just kind of would have been great feature because there is no "Home" button in Macbook. For the same purpose different key map has been setup.

0 votes
niallmuldoon March 6, 2019

Great news! I will have another large PR soon to test with and will post back with any other thoughts.

0 votes
Jiri Hana
Contributor
March 6, 2019

Not sure if I understand you correctly, but pressing "Home" takes me to the top easily.

0 votes
Manish Maharjan March 6, 2019

File tree at right hand side is handy to see folder structure and its hierarchy, however lets say that there are 100 files committed then in old PR version it was possible to see list of files that has been changed on top easily. This was giving us possibility to already skim through the list of files and go through files in easy manner. In newer version we do not have that list of files shown on top anymore. Therefore, not the very nice user experience. 

 

Also, it was not possible to hover over a filename to view full file path or to expand it.

Additionally, if there was a goto top icon when page eventually scrolls would have been very nice. This would reduce time in scrolling all the way to the top if there are 100's of files being expanded in the commit and page size is very large. 

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
March 5, 2019

The 100 file limit has now been lifted.

On a related note, we are aware of some performance issues with large diffs and are working to resolve them.

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
March 5, 2019

Hi Manish,

The file tree in the sidebar is intended to replace the file list from the old experience. Does that not serve the same purpose for you? Let me know!

Also - if filenames are cut off, you can click and drag the edge of the sidebar to expand it, or you can hover over a filename to view a tooltip of the full filename to the side.

Alastair

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
March 5, 2019

A bit late, but still worth following up: in January, we shipped the ability to exclude paths from the new PR experience.

Learn more here: https://bitbucket.org/blog/exclude-files-from-the-new-pull-request-experience

0 votes
Manish Maharjan March 5, 2019

At least, would have been nice user experience if these features were also ported soon. :) 

0 votes
Manish Maharjan March 5, 2019

New version is really annoying when we cannot see whole picture on what files has been changed without any need to jump into the code.

Basically, old view have possibility to view list of committed files in PR, but new one doesn't and also does not show full path if it is too long. 

Also opening a file and browsing a code is too slow when code lines are too long...

0 votes
Kyrylo Omelchenko
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
January 31, 2019

Hi Alastair,

 

I see. My issue is with the diffs.

 

Thanks!

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
January 30, 2019

Hi Kyrylo,

Right now syntax highlighting only works in code blocks in comments and PR descriptions. We haven't added syntax highlighting to the actual diffs yet, but we plan to.

Are you seeing this issue in comments or descriptions?

Alastair

0 votes
Kyrylo Omelchenko
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
January 30, 2019

Hi,

 

Am I the only one having trouble with syntax highlighting? Does not work for me with python source code.

 

Thanks!

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
January 23, 2019

Hi Niall,

It's not possible right now, but we plan to remove that limit in an upcoming update. Thanks!

Alastair

0 votes
niallmuldoon January 23, 2019

Hi,

 

Is it possible to increase the 100 file limit? I have a large pull request and can only see part of it.

 

Thank you!

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
December 21, 2018

Hi Sébastien,

Thanks for the feedback. We will definitely continue to iterate on the activity feed before rolling out to all customers; what you see now is not the finished version.

That said, adding special support for force pushes is not in scope for this redesign, but we may consider it for the future.

Thanks,

Alastair

0 votes
sgautrin
Contributor
December 20, 2018

> A very basic activity feed has been added to the sidebar (without links -- see below)

It seems a bit too basic in how it handles updates adding multiple commits: it seems it only lists the most recent commit in an update instead of listing all added commits or at least the number of commits added.

Indicating if it is force push would be nice as well (I seemed to remember the old activity feed did it, but looking at it the old activity feed did not and has issues with displayed relative time and commits previously added to the PR and later on replaced by others with a force push; maybe I remember incorrectly or it changed since the last time I had used it)

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
December 19, 2018

Thank you all for trying out the new UI and for all the feedback! It's very helpful in prioritizing our backlog.

I wanted to provide a quick update on some improvements we've recently made to the new pull request experience:

  • We've made lots of changes to improve rendering speed and scrolling performance
  • Error handling has been improved
  • You can now expand/collapse all files (in the three-dot menu next to each file)
  • "Ignore whitespace" is now available (in the three-dot menu next to each file)
  • Jira issue keys in pull request titles are now rendered as links
  • A very basic activity feed has been added to the sidebar (without links -- see below)
  • Lots of bug fixes

Next up:

  • Additional performance improvements
  • Ability to auto-hide diffs based on a configurable pattern
  • Scroll-to-comment from email links and activity feed items

Thanks!

Alastair

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
December 19, 2018

Thanks for the feedback, Nick! We're planning to add that improvement.

0 votes
Nick
I'm New Here
I'm New Here
Those new to the Atlassian Community have posted less than three times. Give them a warm welcome!
December 17, 2018

If you have a file in a diff collapsed and click that file in the tree I feel like that file should expand in the main view.

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
November 29, 2018

Ah, I see you replied to my comment on the public issue. Let's continue the discussion there, if that's OK!

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
November 29, 2018

Yes, that feedback is from developers writing comments in Bitbucket :)

While I can't share more specific details about customer feedback or statistics, I do agree that the use case for Bitbucket is indeed a bit different, and we need to make sure it's a great experience for developers (especially being able to create content in the editor efficiently without having to use the mouse).

As I mentioned on the public issue, it seems the common themes are

  • Creating content efficiently without using the mouse - which we've tried to resolve by supporting almost all Markdown + other common keyboard shortcuts
  • Resolving content formatting errors - which we've tried to resolve by making it easier to "break out" of formatting blocks using the arrow keys on your keyboard
  • Bugs - of which we have resolved hundreds in the last year (but keep letting us know if you hit one!)

In your opinion, what problem areas are we missing with the new editor? Can we improve the code blocks? There's also some feedback about pasting Markdown -- is that a key issue for you? Let us know through the Feedback button in the editor itself; we read every comment!

Best,

Alastair

0 votes
Deleted user November 29, 2018

@Alastair Wilkes is that feedback from developers writing comments in Bitbucket pull requests or from across the whole Atlassian suite (Jira, Confluence, etc)?

I ask as I see the use case for Bitbucket as very different to the rest.

I would love to see some statistics if you had them

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events