You're on your way to the next level! Join the Kudos program to earn points and save your progress.
Level 1: Seed
25 / 150 points
1 badge earned
Challenges come and go, but your rewards stay with you. Do more to earn more!
What goes around comes around! Share the love by gifting kudos to your peers.
Keep earning points to reach the top of the leaderboard. It resets every quarter so you always have a chance!
Join now to unlock these features and more
I want to require that selected reviewers in a given review sign off before a review can be completed. Currently we have a few developers that will add domain owners + a few other reviewers, and then once they have a couple senior devs respond (regardless of whether they are the domain owners), the author thinks that is enough and proceeds. I know that there is a prompt warning that people have not responded yet, but there is nothing to block it, so they just close it and merge.
I'd like the option to enable more restriction around when a review can close, by either :
a) Marking selected reviewers as Required, and block the author from closing until those reviewers complete.
b) Having the option to require that ALL added reviewers complete before it can close, and then implement the automatic add of reviewers for a given repo.
Is there existing functionality that will allow this, or anything similar? Apologies if it's been asked before, but I didn't find anything similar in search.
In Crucible 4.2 we introduced new "Workflow Conditions" API. You could use it to write your own plugin with the rule requested. Here is the tutorial:
You can have a (not great) workaround by configuring permissions so that only a designated user account (like a project Lead) or a designated Moderator role (Quality) is actually allowed to Close reviews. They still have to manually confirm that all the "required" Reviewers are marked Complete, but it's better than nothing.
Lead/Moderator/Admin can't force a Reviewer account back to 'Uncomplete' if they think they need to look more/again, which is another feature request in the backlog, FYI.
This feature is currently not available, though I was able to find a feature request for this, which you can see at https://jira.atlassian.com/browse/CRUC-3808. Please feel free to vote and add any comments to it, as well as adding yourself as a watcher so you can track its progress directly. You may refer to Atlassian's policy for the implementation of new features.