Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

When looking at a Pull-Request is there a simple way to see changes between specific commits?

Jeremy October 20, 2013

Here's an example sceneario:

  1. I create a pull request for a branch. My work gets QA'd and/or code reviewed.
  2. I make a bunch of commits to respond to the comments and testing.
  3. My coworker who is reviewing my changes would like to be able to easily see in the pull request which files have changed since he last reviewed. There may be dozens of "changed" files in the branch and doesn't want to re-read everything.

Is there a way (add-on?) that one can easily see this?

2 answers

0 votes
cofarrell
Rising Star
Rising Star
Rising Stars are recognized for providing high-quality answers to other users. Rising Stars receive a certificate of achievement and are on the path to becoming Community Leaders.
October 21, 2013

Hi Jeremy,

It depends a little on your workflow. If your co-worker makes logical commits (ie groups related changes), then I'm personally a big fan of the commenting on commits feature:

https://jira.atlassian.com/browse/STASH-2511

This is something we're hopefully (but I can't promise anything) going to be working on in the not-too-distant-future.

Otherwise, or additionally, you may be interested in something along the lines of being able to compare a branch to another commit. This work may fall somewhere under these features:

https://jira.atlassian.com/browse/STASH-3276

https://jira.atlassian.com/browse/STASH-2550

You may want to follow/vote on any of these issues you are interested in to receive further updates.

As for a plugin - I'm afraid there's none that I know of.

Cheers,

Charles

0 votes
Andrew Milne October 21, 2013

In the pull request page there's a commit tab that shows all the individual commits that make up the pull request. There's no way I've seen to merge all the commits since an arbitrary time point (e.g. the last review pass) but the reviewer can at least use this to look at individual commits since the first review.

Not so good however if you make one commit and then a second that over-writes the changes in the first. If you keep your review comment updates down to a single commit (or squash them with git rebase into one commit prior to pushing) it would probablly make things easier on your reviewer.

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events