When reviewing a Pull Request in Stash I quite like to work as follows:
This is slightly sub-optimal currently because for step 5 I have to either go Back through all the files until I get to the list of the commits, and then choose the next commit (keeping progress in memory), or find the pull request directly and view its commits, neither of which is great, and moreover I'd like to do it all conveniently using keyboard only. Ideally there would be a shortcut that moves to the next (or previous) commit in the list, from the changeset list, or perhaps using J for "next change" at the end of a changeset would take you to the first change in the next commit.
I'm using v2.0.2. Am I missing a way of doing this easily?
Because all the Commits in a Pull Request, while usually logically related, can (and usually do to some extent) have different specific purposes, e.g. "Add Foo() method", "Add DB table", "Tests", "Refactor", "Format source code". Sometimes you can look at the combined diff and appreciate it all together, but at other times I look at the big list of changed files and wish I could break it down a bit, depends on the situation which will be better. I'm sure there are arguments for tweaking the number of commits and pull requests for easy comprehension, but I still need to review things that aren't ideal, and I think even when these are essentially ideal I experience the problem.
Does that make sense?
One other thing that's just occurred to me (while I was working through a PR commit by commit...) is that if you're looking at a commit you can't comment on anything you see directly, you have to go back to the PR, find the changed file in the combined diff, and then comment. I can see why that is, but it's inconvenient for me sometimes. I don't know how you'd deal with situations where a line in a commit is not actually the same as in the resulting PR overall because it's changed in a later commit, but perhaps that would be a convenient thing to display graphically too, "don't bother looking at this too hard because it's changed again!"
I have a huge pull request waiting for me to review it and I just had the same thought as you @Richard Hooper. It would be great if I could review it one commit at a time and quickly move to the next one using keyboard shortcuts or even screen buttons, just without having to go back to commit list.
I'm using BitBucket Cloud.
Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda ...
Connect with like-minded Atlassian users at free events near you!Find a group
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no AUG chapters near you at the moment.Start an AUG
We're bringing product updates and pro tips on teamwork to ten cities around the world.Save your spot