It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Any way to mark a pull request as "unapproved" other than with a comment or declining?

Comming from a gerrit background, I liked the fact that gerrit allowed you to mark a code review with a -1 or -2 (to block it). In stash you can approve a pull request to show that you agree with it but you can't mark the pull request as denied.

Declining a pull request is like abandonning a review in gerrit. I'd like to have a Deny button that you can toggle just so that it's easy to spot that a someone disaproves of your pull request.

Disaproving wouldn't block a pull request but it would be a great visual cue in the summary section to show that someone is protesting against your pull request (maybe put a little red mark in the avatar, akin to the green cross when someone approves).

3 answers

1 accepted

0 votes
Answer accepted

Partially you can use Handbrake plugin for this.

https://bitbucket.org/Commander_Duck/stash-pull-request-handbrake

Thanks, it's not exactly what I'm looking for but I chose this one as the best answer because it inspired me to try to write a plugin to scratch my itch.

Hi Fred,

As Robert pointed out we don't currently support this. I think there's definitely room for improvement of the pull request reviewer states - but we're being cautious about exactly how we implement it.

While this isn't exactly what you're asking for, you might want to vote on the following which I suspect from an implementation perspective would result in what you're asking for.

https://jira.atlassian.com/browse/STASH-2999

Otherwise feel free to create a new feature request so we can track specific interest.

Cheers,

Charles

Unfortunately, no. You can approve or not approve, but you can't do a -1.

Suggest an answer

Log in or Sign up to answer
This widget could not be displayed.
This widget could not be displayed.
Community showcase
Published Mar 14, 2019 in Bitbucket Pipelines

Building a Bitbucket Pipe as a casual coder

...ipe.sh :  #!/bin/bash source "$(dirname "$0")/common.sh" enable_debug extra_args="" if [[ "${DEBUG}" == "true" ]]; then extra_args="--verbose" fi # mandatory variables R...

1,027 views 1 16
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you