Come for the products,
stay for the community

The Atlassian Community can help you and your team get more value out of Atlassian products and practices.

Atlassian Community about banner
4,362,610
Community Members
 
Community Events
168
Community Groups

Adding user to pull request does not prioritize users with repo write access

When creating a pull request I cannot find users reliably. For example, in pics below Chris Brewer is a user with write accessatlassianbug2.png

However when I try to add him to a pull request he is not in the search results - including if you scroll it down. You cannot add by email address either

atlassianbug1.png

It seems like users with write access to the repo should be high priority search candidates. I have seen this problematic behavior in other user input selector dialog boxes.

1 answer

0 votes

Hi @andytomlin,

I triggered a sync in our permissions system for this user and for the repository. Could you please check if you are able to find this user now when adding reviewers to a PR of this repo?

Kind regards,
Theodora

Theodora,

  We worked around the problem with Chris by having him navigate to the pull and make a comment. This then put him at the top of the list to be added to the pull.

However Ashwini Kumar is the same test case - he has permissions to the repo. Unfortunately I cant tell if he is the correct reviewer as there are a lot of Ashwini Kumar's. I have asked him to add a unique pic to his profile so when he does that I will retest. 

Either way it sucks not to be able to add reviewers via email address in a public repo. The current dialog is pretty useless as you just have a long list of names and no way to discriminate or tell if its the right or the wrong user. Certainly with Ashwini its not obvious that the Ashwini with write privileges is the first one. Note that in both Chris and Ashwini's cases they had not made a commit to the repo.

Ok, Ashwini added a profile pic and I can confirm he does not show up in the add reviewer drop down. However I see his profile pic in the user and group access in repository settings.

It is definitely a bug

I would recommend any dialog box where your selecting a user you allow the use of email address.

Hi @andytomlin,

I made the same sync for the user Ashwini that has access to your repo.

Could you please let me know if you are able to find this user now when adding PR reviewers?

Users with access to the repo should have a label 'MEMBER' next to their name in the user picker dropdown, as follows:

Screenshot 2022-09-02 at 12.39.16.png

If a user doesn't have this, it's not one of your users with explicit access.

I have created a request for prioritizing users with explicit access in that user picker for public repos (this issue occurs with public repos, for private repos only team members are displayed):

Kind regards,
Theodora

I can confirm that syncing the user did not fix the issue. Ashwini is not in the drop down.

Hi @andytomlin,

Just double-checking if you scrolled down the list that shows users past the first 6 results?

If the user still doesn't show, the workarounds I can suggest at the moment would be either asking the user to leave a comment in the PR, like you did with Chris, or alternatively add the user via API by updating the PR:

Kind regards,
Theodora

yes, and the user does not show up

Hi @andytomlin,

I have reached out to the development team to check if there is anything more we can do. I'll let you know as soon as I have an update.

Kind regards,
Theodora

Hi @andytomlin,

I reached out to the development team, the user picker recommends users to select as a reviewer based on how much the user has commented, mentioned others, or been mentioned.

Our suggestion would be to ask the user to leave a comment in the PR, like you did before with Chris, so that the user gets prioritized. The other workaround would be adding the user as a PR reviewer via our API.

Kind regards,
Theodora

Yes, we know how it can be worked around, but its a bit clunky. I would still recommend adding ability to add user by email.

Hi @andytomlin,

I understand what you're saying, I have modified the feature request I opened earlier to make it specifically about adding PR reviewers via email.

I also found that we have an existing bug report about team members not being prioritised as PR reviewers in public repos: https://jira.atlassian.com/browse/BCLOUD-21226
I would suggest selecting the "This affects my team" link in there to indicate you are affected by this.

When we have an update for either issue, it will be posted in the respective feature request or bug report.

Kind regards,
Theodora

Suggest an answer

Log in or Sign up to answer
DEPLOYMENT TYPE
CLOUD
PERMISSIONS LEVEL
Site Admin
TAGS

Atlassian Community Events