Quality Gating

[kanav002]

Is there a way to block code reviews if test conditions in the pipeline fail? This would make sure that the developer doesn't call a code review until they have addressed all issues in the automated testing stages.

[Felipe Kraemer · Accepted solution]

Hi @kanav002,

Thanks for clarifying. Currently it is not possible, via web interface, to block Crucible code reviews from being created or worked on if test conditions in the pipeline fail. 

If you create reviews from the command line though, it is possible to customize the Crucible Python script, making it check for these automated test results someway when it is executed (maybe via some REST API provided by your automation tool?), and block the code review creation if any of the automated tests have failed.

Just please bear in mind that customizations are not supported by Atlassian, so if you face any problems using the Crucible Python script after customizing it your best option is to ask for help in Atlassian Community website.

Regards,

Felipe

[kanav002]

Thank you Felipe that was helpful!

Besides using customized scripts for gating, do you know if Atlassian supports any other services for CI/CD gating of code reviews? 

Nick

[Felipe Kraemer]

Hi Nick,

I believe Atlassian Bamboo is a great solution for that. With Bamboo you can checkout the repository source code, perform the automated tests and, if they are successful, run a script task that calls Crucible Python script in order to create the review.

Cheers,

Felipe 

[kanav002]

Hi Felipe,

Thank you again! That was very helpful.

Nick

[Felipe Kraemer]

Hi @kanav002,

This question was created in Fisheye/Crucible space but you have mentioned 'pipelines', which is a Bitbucket Cloud feature. 

Therefore, we would like to confirm if, by 'code reviews' you are referring to Crucible reviews or to Bitbucket pull requests.

Can you please clarify that?

Regards,

Felipe

[kanav002]

Hi Felipe,

I was referring to Crucible reviews.

Thanks,

Nick