How do I post a code review for a draft commit in Mercurial?

Hi,

Our developer setup is such that we have a central Mercurial repository on one of our servers and each developer has a clone of this repository. When a developer makes a change, we commit locally (via hg commit) and for the code review, we use hg serve to provide a web interface within the browser to the local clone of the repository and to the draft commit. Then, once we have achieved signoff, we use hg push to push the change to the central repository. This seems like it would be a very common flow.

However, I have been unable to find any information on how to easily post a review from a draft commit (i.e, one made via hg commit, but not pushed yet) on one of these peripheral clones. Our central repository is added and indexed, but we obviously don't want to index each individual's clone, as well. What is the best workflow to achieve what we need?

Thanks,

Robert

1 answer

1 accepted

This widget could not be displayed.

Hi Robert,

I think this could be achieved by using Patch files for a pre-commit review. For this you would basically create a patch (a diff with the latest change) and upload it to the review. I'm not sure if Crucible is able to anchor a patch generated as per this Mercurial workflow you described, but I think it's worth to try.

Furthermore, if we are talking about new files, as they can't be anchored, I think you could upload new files as Attachments.

Regards,

Gustavo Refosco

Thanks, I just came across the line in https://confluence.atlassian.com/display/CRUCIBLE/Creating+reviews+from+the+command+line which indicates that this is a limitation in the CLI. Is there a place to upvote a feature request for this?

Hi Robert, The only improvement requests I could find about the CLI tool are listed at the following URL: https://jira.atlassian.com/browse/CRUC-6840?jql=project%20%3D%20CRUC%20AND%20issuetype%20in%20%28Improvement%2C%20%22New%20Feature%22%29%20AND%20text%20~%20%22CLI%20tool%22 It seems there is none for the known limitations listed in that page, but please feel free to create one describing your suggestions at https://jira.atlassian.com You may also check on Atlassian's Feature Requests Policy at http://confluence.atlassian.com/display/DEV/Implementation+of+New+Features+Policy Regards, Gustavo Refosco

Suggest an answer

Log in or Sign up to answer
Atlassian Summit 2018

Meet the community IRL

Atlassian Summit is an excellent opportunity for in-person support, training, and networking.

Learn more
Community showcase
Posted yesterday in Statuspage

What are your best incident management tips and stories? #HugOps

 👋Community members! Downtime happens. And great incident response takes a village. Teams like Support, Dev, SRE, Ops, IT, and Marketing have to come together to resolve the problem while keep...

40 views 2 3
Join discussion

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you