It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage
Highlighted

Issue: Incorrect history & notification text when a pull request is auto-unapproved Edited

I have a complaint about how Bitbucket describes automated approval retraction for a changed Pull Request. 

Right now, there isn't a distinction in the PR history or notifications between a reviewing user that deliberately retracts their approval versus when the PR automatically retracts that approval upon the branch receiving a new commit.  Since the reviewer isn't the one actually un-approving the PR, the text as currently shown is incorrect, as it states that the approval retraction was that user's own action.

 

To recreate:

Make a pull request for a branch with commits.

Add a reviewer.  We'll call her "Barb".

Have "Barb" approve the request.

Push a new commit to the branch.

What currently happens:

I receive a notification that "Barb" has marked the PR as unapproved.

The PR overview/history shows that "Barb" marked the PR as unapproved.

What should happen:

The notification should communicate in some manner that Bitbucket has retracted Barb's approval (and the approval of any other reviewers) because a new commit was added to the branch.

The PR overview/history should also show that Bitbucket retracted all approval(s) because a new commit was added to the branch.

1 comment

Your question inspired us to implement an improved "auto-unapprover" in our paid add-on, PR-Booster for Bitbucket Server.

Here's the config screen:

pr-booster.png

And here's the end-result:

pr-booster-history.png

Our add-on allows the auto-unapprover to be enabled globally, per-project, or per-repo.  We also implemented functionality for retaining "needs work" reviews, which normally get dropped the moment the PR receives any new commits.

We use a special "PR-Booster - Approval Reset Bot - New Commits Detected" service user to make the unapprove actions understandable on the PR history.

Install PR-Booster for Bitbucket Server to try this out!

 

Comment

Log in or Sign up to comment
TAGS
Community showcase
Published in Bitbucket

Powering DevOps with Bitbucket Server & Data Center

Hi everyone, The Cloud team recently announced 12 new DevOps features that help developers ship better code, faster   ! While we’re all excited about the new improvements to Bitbucket ...

1,537 views 0 6
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you