nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

code review: how to navigate to the next file is not marked as viewed?

Yevhen Kozlov_lfa8ct

Let's say I have PR with 50+ files.

Then if I try to see files not marked as viewed yet, I end up with next recipe:

1. collapse all the files

2. look for files without checkbox

3. expand them one by one

It's suboptimal especially because moved/deleted files does not persist "Viewed" mark(https://jira.atlassian.com/browse/BCLOUD-23186)

In "only one file at once" mode it becomes even more brutal.

Yes, there is a sidebar with files explorer. But it has a separate flaw - if a file inside the folder is "unviewed", folder name is not listed in bold.

This way, if many files is affected, reviewing becomes pretty painful.

May you know an existing ticket in backlog on this so I could vote for it?

Accepted answers

Theodora Boudale

Hi @Yevhen Kozlov and welcome to the community!

Thank you for reaching out.

I think that using the left sidebar may be a more convenient way to navigate to unviewed files and always expand any folders listed there. Expanding the folders in the sidebar should be easier than collapsing all the files and looking for files without a checkbox, but I understand that the folder name not being in bold might make it harder to remember to expand.

You asked if there is an existing ticket in the backlog so you can vote for it. Are you asking for a ticket with the request to display the folder name in the sidebar in bold when it has unviewed files? Or is your request about something different, about a different way to navigate the unviewed files? Can you please confirm and explain? I can then check if there is a ticket, otherwise, I can create it.

Kind regards,
Theodora

All comments

Theodora Boudale

Hi @Yevhen Kozlov and welcome to the community!

Thank you for reaching out.

Kind regards,
Theodora

Yevhen Kozlov_lfa8ct

Thank you Theodora, I appreciate your comment on that

Still I think current UI is not optimal for big PRs.

What if I have a PR with 138 files changed, there are 3 of them not marked as "Viewed". I need to scroll file tree in side bar pretty slowly to notice first file in bold font. And to reach next file to review. And next.

I think anything would work:

1. in "Show files individually" it could be a button or shortcut "next unviewed file", just like we have "Next file"(or shortcut "j")

2. or file explorer in side bar may have filter "hide viewed"

3. ... or file explorer in side bar could mark folder with bold font if any file inside of it(including subfolders) is not marked as viewed yet

Probably 2 or 3 would be more useful since 1 does not make sense when all the files' changes are shown at the same time(it's possible even with that many files in PR - if most have 1 or 2 lines updated)

PS By now I'm sequentially calling `document.querySelector('.css-h8ii0d').scrollIntoView()` in browser devtools' Console to scroll sidebar's file explorer to first "unviewed". It works but is suboptimal - classname changes through time

Theodora Boudale

Hi Yevhen,

Thank you very much for the detailed response. I appreciate the feedback and I understand the challenge you described.

I couldn't find any existing tickets for the things you asked, so I created three separate feature requests, one for each of your suggestions:

You can add your vote to these feature requests (by selecting the link Vote for this issue) to increase the chances of them being implemented. You are more than welcome to leave feedback, and you can also add yourself as a watcher (by selecting the link Start watching this issue) if you'd like to be notified via email on updates.

Implementation of features is done as per our policy here and any updates will be posted in the feature request.

Please feel free to reach out if you have any questions.

Kind regards,
Theodora

Welcome!

It looks like you're new here. Sign in or register to get started.

Quick Links

Find more posts tagged with

cloud

bitbucket

bitbucket-cloud

pull-request